bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-17 00:33:44 +00:00
Code Issues Releases Wiki Activity

Auth/PM-8358 - User Verification dialog & form input fix for empty submit displaying wrong error (#9363)

Browse Source 
* PM-8358 - UserVerificatonFormInput - fix incorrect init logic. We needed to execute the processSecretChanges logic to convert null into { type: 0, secret: null }  (VerificationWithSecret) for all non-biometric verification flows. .

* PM-8358 - UserVerificationService - verifyUser(...) - throw error if called with null. It should only happen if a dev makes a mistake in theory.
This commit is contained in:
Jared Snider
2024-06-03 10:15:11 -04:00
committed by GitHub
parent 13bccc5a63
commit 01648e2cc3
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
libs/auth/src/angular/user-verification/user-verification-form-input.component.ts
View File

@@ -197,8 +197,8 @@ export class UserVerificationFormInputComponent implements ControlValueAccessor,
}
}
// Don't bother executing secret changes if biometrics verification is active.
if (this.activeClientVerificationOption === ActiveClientVerificationOption.Biometrics) {
// Executing secret changes for all non biometrics verification. Biometrics doesn't have a user entered secret.
if (this.activeClientVerificationOption !== ActiveClientVerificationOption.Biometrics) {
this.processSecretChanges(this.secret.value);
}