bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-16 08:13:42 +00:00
Code Issues Releases Wiki Activity

[PM-4816] Create shared LoginApprovalComponent (#11982)

Browse Source 
* Stub out dialog

* Genericize LoginApprovalComponent

* update ipc mocks

* Remove changes to account component

* Remove changes to account component

* Remove debug

* Remove test component

* Remove added translations

* Fix failing test

* Run lint and prettier

* Rename LoginApprovalServiceAbstraction to LoginApprovalComponentServiceAbstraction

* Add back missing "isVisible" check before calling loginRequest

* Rename classes to contain "Component" in the name

* Add missing space between "login attempt" and fingerprint phrase

* Require email
This commit is contained in:
Alec Rippberger
2024-11-22 12:55:26 -06:00
committed by GitHub
parent 13d4b6f2a6
commit 02ea368446
12 changed files with 307 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
libs/auth/src/common/abstractions/index.ts
View File

@@ -4,3 +4,4 @@ export * from "./login-email.service";
export * from "./login-strategy.service";
export * from "./user-decryption-options.service.abstraction";
export * from "./auth-request.service.abstraction";
export * from "./login-approval-component.service.abstraction";

9
libs/auth/src/common/abstractions/login-approval-component.service.abstraction.ts Normal file
View File

@@ -0,0 +1,9 @@
/**
* Abstraction for the LoginApprovalComponent service.
*/
export abstract class LoginApprovalComponentServiceAbstraction {
/**
* Shows a login requested alert if the window is not visible.
*/
abstract showLoginRequestedAlertIfWindowNotVisible: (email?: string) => Promise<void>;
}