bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-12 14:23:32 +00:00
Code Issues Releases Wiki Activity

[PM-19022] Separate Manage Account Recovery and Manage Users custom role (#14629)

Browse Source 
* Add SeparateCustomRolePermissions feature flag

* Allow 'Manage Account Recovery' to be configured separately from 'Manage Users'
This commit is contained in:
Rui Tomé
2025-05-08 20:00:42 +01:00
committed by GitHub
parent 7b35ed9d55
commit 0407ed5b90
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
apps/web/src/app/admin-console/organizations/members/components/member-dialog/member-dialog.component.ts
View File

@@ -456,7 +456,13 @@ export class MemberDialogComponent implements OnDestroy {
return Object.assign(p, partialPermissions); return Object.assign(p, partialPermissions);
} }
handleDependentPermissions() { async handleDependentPermissions() {
const separateCustomRolePermissions = await this.configService.getFeatureFlag(
FeatureFlag.SeparateCustomRolePermissions,
);
if (separateCustomRolePermissions) {
return;
}
// Manage Password Reset (Account Recovery) must have Manage Users enabled // Manage Password Reset (Account Recovery) must have Manage Users enabled
if ( if (
this.permissionsGroup.value.manageResetPassword && this.permissionsGroup.value.manageResetPassword &&

2
libs/common/src/enums/feature-flag.enum.ts
View File

@@ -13,6 +13,7 @@ export enum FeatureFlag {
LimitItemDeletion = "pm-15493-restrict-item-deletion-to-can-manage-permission", LimitItemDeletion = "pm-15493-restrict-item-deletion-to-can-manage-permission",
SsoExternalIdVisibility = "pm-18630-sso-external-id-visibility", SsoExternalIdVisibility = "pm-18630-sso-external-id-visibility",
AccountDeprovisioningBanner = "pm-17120-account-deprovisioning-admin-console-banner", AccountDeprovisioningBanner = "pm-17120-account-deprovisioning-admin-console-banner",
SeparateCustomRolePermissions = "pm-19917-separate-custom-role-permissions",
/* Auth */ /* Auth */
PM9112_DeviceApprovalPersistence = "pm-9112-device-approval-persistence", PM9112_DeviceApprovalPersistence = "pm-9112-device-approval-persistence",
@@ -83,6 +84,7 @@ export const DefaultFeatureFlagValue = {
[FeatureFlag.LimitItemDeletion]: FALSE, [FeatureFlag.LimitItemDeletion]: FALSE,
[FeatureFlag.SsoExternalIdVisibility]: FALSE, [FeatureFlag.SsoExternalIdVisibility]: FALSE,
[FeatureFlag.AccountDeprovisioningBanner]: FALSE, [FeatureFlag.AccountDeprovisioningBanner]: FALSE,
[FeatureFlag.SeparateCustomRolePermissions]: FALSE,
/* Autofill */ /* Autofill */
[FeatureFlag.BlockBrowserInjectionsByDomain]: FALSE, [FeatureFlag.BlockBrowserInjectionsByDomain]: FALSE,