From 0478836be0d95a86b5e8f3e296d8a7bc520a9c5e Mon Sep 17 00:00:00 2001 From: Leslie Tilton <23057410+Banrion@users.noreply.github.com> Date: Fri, 23 Jan 2026 14:12:06 -0600 Subject: [PATCH] Filter web addresses --- .../services/phishing-data.service.ts | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/apps/browser/src/dirt/phishing-detection/services/phishing-data.service.ts b/apps/browser/src/dirt/phishing-detection/services/phishing-data.service.ts index 77c222670d0..2bf10eb93d6 100644 --- a/apps/browser/src/dirt/phishing-detection/services/phishing-data.service.ts +++ b/apps/browser/src/dirt/phishing-detection/services/phishing-data.service.ts @@ -239,8 +239,20 @@ export class PhishingDataService { "[PhishingDataService] Dev flag enabled for testing phishing detection. Adding test phishing web addresses:", webAddresses, ); - // Normalize dev flag URLs as well - const normalizedDevAddresses = (webAddresses as string[]).map((addr) => new URL(addr).href); + // Normalize dev flag URLs as well, filtering out invalid ones + const normalizedDevAddresses = (webAddresses as string[]) + .filter((addr) => { + try { + new URL(addr); + return true; + } catch { + this.logService.warning( + `[PhishingDataService] Invalid test URL in dev flag, skipping: ${addr}`, + ); + return false; + } + }) + .map((addr) => new URL(addr).href); return testWebAddresses.concat(normalizedDevAddresses); } return testWebAddresses; @@ -378,7 +390,7 @@ export class PhishingDataService { return from(this._phishingMetaState.update(() => result.meta)).pipe( tap(() => { const elapsed = Date.now() - startTime; - this.logService.info(`[PhishingDataService] Updated in ${elapsed}ms`); + this.logService.info(`[PhishingDataService] Updated data set in ${elapsed}ms`); }), ); }),