From 05f6a30672a5390edf43279f4d8bf034fb6b4be2 Mon Sep 17 00:00:00 2001 From: "Patrick H. Lauke" Date: Mon, 25 Jul 2022 11:43:10 +0100 Subject: [PATCH] [PS-1182] Desktop / Browser: Accessibility - remove appBlurClick, change remaining links to buttons (#2662) * Remove `appBlurClick` from browser extension controls * Remove last remaining `appBlurClick` from desktop app controls * Change any straggler `` links to buttons where appropriate (where they don't open a browser window) * Add missing `type="button"` to some of the desktop buttons * Update and run prettier, linter * Remove orphaned jslibs --- .../popup/accounts/environment.component.html | 4 +- .../src/popup/accounts/hint.component.html | 4 +- .../src/popup/accounts/home.component.html | 14 +++--- .../src/popup/accounts/lock.component.html | 3 +- .../src/popup/accounts/login.component.html | 7 ++- .../popup/accounts/register.component.html | 6 +-- .../accounts/set-password.component.html | 6 +-- .../two-factor-options.component.html | 2 +- .../popup/accounts/two-factor.component.html | 3 +- .../update-temp-password.component.html | 4 +- .../password-reprompt.component.html | 3 +- .../popup/components/set-pin.component.html | 3 +- .../popup/generator/generator.component.html | 6 +-- .../password-generator-history.component.html | 4 +- .../popup/send/send-add-edit.component.html | 6 +-- .../popup/send/send-groupings.component.html | 3 -- .../src/popup/send/send-type.component.html | 3 +- .../settings/excluded-domains.component.html | 7 ++- .../src/popup/settings/export.component.html | 6 +-- .../settings/folder-add-edit.component.html | 5 +- .../src/popup/settings/folders.component.html | 11 ++--- .../src/popup/settings/options.component.html | 4 +- .../src/popup/settings/premium.component.html | 9 ++-- .../popup/settings/settings.component.html | 48 ++++++++++--------- .../src/popup/settings/sync.component.html | 4 +- apps/browser/src/popup/tabs.component.html | 5 ++ .../add-edit-custom-fields.component.html | 1 - .../src/popup/vault/add-edit.component.html | 14 +----- .../popup/vault/attachments.component.html | 7 ++- .../src/popup/vault/ciphers.component.html | 6 +-- .../popup/vault/collections.component.html | 4 +- .../popup/vault/current-tab.component.html | 3 +- .../vault/password-history.component.html | 2 +- .../src/popup/vault/share.component.html | 3 +- .../popup/vault/vault-filter.component.html | 16 +------ .../src/popup/vault/view.component.html | 17 ++----- .../app/accounts/set-password.component.html | 2 +- .../src/app/components/set-pin.component.html | 2 +- .../layout/account-switcher.component.html | 2 +- apps/desktop/src/app/send/send.component.html | 7 ++- 40 files changed, 110 insertions(+), 156 deletions(-) diff --git a/apps/browser/src/popup/accounts/environment.component.html b/apps/browser/src/popup/accounts/environment.component.html index 626c5b7b3eb..a23de6ff56a 100644 --- a/apps/browser/src/popup/accounts/environment.component.html +++ b/apps/browser/src/popup/accounts/environment.component.html @@ -1,13 +1,13 @@
- {{ "close" | i18n }} +

{{ "appName" | i18n }}

- diff --git a/apps/browser/src/popup/accounts/hint.component.html b/apps/browser/src/popup/accounts/hint.component.html index b4fbfdc05a4..828af9c5583 100644 --- a/apps/browser/src/popup/accounts/hint.component.html +++ b/apps/browser/src/popup/accounts/hint.component.html @@ -1,13 +1,13 @@
- {{ "cancel" | i18n }} +

{{ "passwordHint" | i18n }}

- diff --git a/apps/browser/src/popup/accounts/home.component.html b/apps/browser/src/popup/accounts/home.component.html index 2fb6907dccf..5f80204a27b 100644 --- a/apps/browser/src/popup/accounts/home.component.html +++ b/apps/browser/src/popup/accounts/home.component.html @@ -2,15 +2,17 @@

{{ "loginOrCreateNewAccount" | i18n }}

- {{ "login" | i18n }} + - {{ "createAccount" | i18n }} +
- + diff --git a/apps/browser/src/popup/accounts/lock.component.html b/apps/browser/src/popup/accounts/lock.component.html index 04e6eb1e102..ed47940875d 100644 --- a/apps/browser/src/popup/accounts/lock.component.html +++ b/apps/browser/src/popup/accounts/lock.component.html @@ -5,7 +5,7 @@ {{ "verifyIdentity" | i18n }}
- +
@@ -41,7 +41,6 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'toggleVisibility' | i18n }}" (click)="togglePassword()" [attr.aria-pressed]="showPassword" diff --git a/apps/browser/src/popup/accounts/login.component.html b/apps/browser/src/popup/accounts/login.component.html index d82d214fb2e..281df835093 100644 --- a/apps/browser/src/popup/accounts/login.component.html +++ b/apps/browser/src/popup/accounts/login.component.html @@ -1,13 +1,13 @@
- {{ "cancel" | i18n }} +

{{ "appName" | i18n }}

- @@ -46,7 +46,6 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'toggleVisibility' | i18n }}" (click)="togglePassword()" [attr.aria-pressed]="showPassword" @@ -65,7 +64,7 @@

- {{ "getMasterPasswordHint" | i18n }} +

diff --git a/apps/browser/src/popup/accounts/register.component.html b/apps/browser/src/popup/accounts/register.component.html index 4c8ec89aac9..82d508e5c79 100644 --- a/apps/browser/src/popup/accounts/register.component.html +++ b/apps/browser/src/popup/accounts/register.component.html @@ -1,13 +1,13 @@
- {{ "cancel" | i18n }} +

{{ "createAccount" | i18n }}

- @@ -46,7 +46,6 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'toggleVisibility' | i18n }}" (click)="togglePassword()" [attr.aria-pressed]="showPassword" @@ -94,7 +93,6 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'toggleVisibility' | i18n }}" (click)="togglePassword()" [attr.aria-pressed]="showPassword" diff --git a/apps/browser/src/popup/accounts/set-password.component.html b/apps/browser/src/popup/accounts/set-password.component.html index b8e89b7693d..969d81c2c30 100644 --- a/apps/browser/src/popup/accounts/set-password.component.html +++ b/apps/browser/src/popup/accounts/set-password.component.html @@ -1,13 +1,13 @@
- {{ "cancel" | i18n }} +

{{ "setMasterPassword" | i18n }}

- @@ -64,7 +64,6 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'toggleVisibility' | i18n }}" (click)="togglePassword(false)" [attr.aria-pressed]="showPassword" @@ -116,7 +115,6 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'toggleVisibility' | i18n }}" (click)="togglePassword(true)" [attr.aria-pressed]="showPassword" diff --git a/apps/browser/src/popup/accounts/two-factor-options.component.html b/apps/browser/src/popup/accounts/two-factor-options.component.html index e70d6a373cd..3fc510bb27c 100644 --- a/apps/browser/src/popup/accounts/two-factor-options.component.html +++ b/apps/browser/src/popup/accounts/two-factor-options.component.html @@ -1,6 +1,6 @@
- {{ "close" | i18n }} +

{{ "twoStepOptions" | i18n }} diff --git a/apps/browser/src/popup/accounts/two-factor.component.html b/apps/browser/src/popup/accounts/two-factor.component.html index 84ad0cc8bb6..b2d017a9f97 100644 --- a/apps/browser/src/popup/accounts/two-factor.component.html +++ b/apps/browser/src/popup/accounts/two-factor.component.html @@ -1,7 +1,7 @@
- {{ "back" | i18n }} +

{{ title }} @@ -9,7 +9,6 @@

- @@ -53,7 +53,6 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'toggleVisibility' | i18n }}" (click)="togglePassword(false)" [attr.aria-pressed]="showPassword" @@ -100,7 +99,6 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'toggleVisibility' | i18n }}" (click)="togglePassword(true)" [attr.aria-pressed]="showPassword" diff --git a/apps/browser/src/popup/components/password-reprompt.component.html b/apps/browser/src/popup/components/password-reprompt.component.html index e57ad7d178d..ed698097356 100644 --- a/apps/browser/src/popup/components/password-reprompt.component.html +++ b/apps/browser/src/popup/components/password-reprompt.component.html @@ -23,7 +23,6 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'toggleVisibility' | i18n }}" (click)="togglePassword()" [attr.aria-pressed]="showPassword" @@ -43,7 +42,7 @@

@@ -9,7 +9,7 @@ {{ "generator" | i18n }}
-
@@ -33,7 +33,6 @@ @@ -9,7 +9,7 @@ {{ "passwordHistory" | i18n }}
-
diff --git a/apps/browser/src/popup/send/send-add-edit.component.html b/apps/browser/src/popup/send/send-add-edit.component.html index 3fea4094d6e..fb1ba6b801c 100644 --- a/apps/browser/src/popup/send/send-add-edit.component.html +++ b/apps/browser/src/popup/send/send-add-edit.component.html @@ -1,13 +1,13 @@
- +

{{ title }}

- @@ -226,7 +226,6 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'toggleVisibility' | i18n }}" (click)="togglePasswordVisible()" [attr.aria-pressed]="showPassword" @@ -300,7 +299,6 @@ type="button" class="box-content-row" appStopClick - appBlurClick (click)="delete()" [appApiAction]="deletePromise" #deleteBtn diff --git a/apps/browser/src/popup/send/send-groupings.component.html b/apps/browser/src/popup/send/send-groupings.component.html index 72c79e7cb77..92c02ee3b34 100644 --- a/apps/browser/src/popup/send/send-groupings.component.html +++ b/apps/browser/src/popup/send/send-groupings.component.html @@ -18,7 +18,6 @@
@@ -21,7 +21,6 @@

{{ "excludedDomains" | i18n }}

- +
@@ -73,7 +73,6 @@

{{ "exportVault" | i18n }}

-
diff --git a/apps/browser/src/popup/settings/folder-add-edit.component.html b/apps/browser/src/popup/settings/folder-add-edit.component.html index 3999f6fb88d..b8aa391f0fa 100644 --- a/apps/browser/src/popup/settings/folder-add-edit.component.html +++ b/apps/browser/src/popup/settings/folder-add-edit.component.html @@ -1,13 +1,13 @@
- {{ "cancel" | i18n }} +

{{ title }}

- @@ -34,7 +34,6 @@ type="button" class="box-content-row" appStopClick - appBlurClick (click)="delete()" [appApiAction]="deletePromise" #deleteBtn diff --git a/apps/browser/src/popup/settings/folders.component.html b/apps/browser/src/popup/settings/folders.component.html index 23e2e227898..5052501d572 100644 --- a/apps/browser/src/popup/settings/folders.component.html +++ b/apps/browser/src/popup/settings/folders.component.html @@ -1,20 +1,15 @@

{{ "folders" | i18n }}

-
diff --git a/apps/browser/src/popup/settings/options.component.html b/apps/browser/src/popup/settings/options.component.html index 877710438c6..8f9874faa71 100644 --- a/apps/browser/src/popup/settings/options.component.html +++ b/apps/browser/src/popup/settings/options.component.html @@ -1,9 +1,9 @@

{{ "options" | i18n }} diff --git a/apps/browser/src/popup/settings/premium.component.html b/apps/browser/src/popup/settings/premium.component.html index a12fd370d28..fad784da6b4 100644 --- a/apps/browser/src/popup/settings/premium.component.html +++ b/apps/browser/src/popup/settings/premium.component.html @@ -1,9 +1,9 @@

{{ "premiumMembership" | i18n }} @@ -42,13 +42,12 @@

{{ priceString }}

- diff --git a/apps/browser/src/popup/settings/settings.component.html b/apps/browser/src/popup/settings/settings.component.html index c7f4bb5042d..af601fad2cb 100644 --- a/apps/browser/src/popup/settings/settings.component.html +++ b/apps/browser/src/popup/settings/settings.component.html @@ -11,18 +11,30 @@
@@ -77,7 +89,6 @@ type="button" class="box-content-row box-content-row-flex text-default" appStopClick - appBlurClick (click)="lock()" >
{{ "lockNow" | i18n }}
@@ -87,7 +98,6 @@ type="button" class="box-content-row box-content-row-flex text-default" appStopClick - appBlurClick (click)="twoStep()" >
{{ "twoStepLogin" | i18n }}
@@ -98,7 +108,7 @@

{{ "account" | i18n }}

- +

{{ "sync" | i18n }} diff --git a/apps/browser/src/popup/tabs.component.html b/apps/browser/src/popup/tabs.component.html index f64837cc732..fd04967b914 100644 --- a/apps/browser/src/popup/tabs.component.html +++ b/apps/browser/src/popup/tabs.component.html @@ -4,6 +4,7 @@
  • +

{{ title }}

- @@ -51,7 +51,6 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'generateUsername' | i18n }}" (click)="generateUsername()" > @@ -77,7 +76,6 @@ type="button" #checkPasswordBtn class="row-btn btn" - appBlurClick appA11yTitle="{{ 'checkPassword' | i18n }}" (click)="checkPassword()" [appApiAction]="checkPasswordPromise" @@ -99,7 +97,6 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'toggleVisibility' | i18n }}" (click)="togglePassword()" *ngIf="cipher.viewPassword" @@ -115,7 +112,6 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'generatePassword' | i18n }}" (click)="generatePassword()" *ngIf="cipher.viewPassword" @@ -165,7 +161,6 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'toggleVisibility' | i18n }}" (click)="toggleCardNumber()" [attr.aria-pressed]="showCardNumber" @@ -219,7 +214,6 @@ type="button" class="row-btn" appStopClick - appBlurClick appA11yTitle="{{ 'toggleVisibility' | i18n }}" (click)="toggleCardCode()" [attr.aria-pressed]="showCardCode" @@ -486,7 +480,6 @@ - @@ -13,7 +13,7 @@ {{ "attachments" | i18n }}

- @@ -33,7 +33,6 @@ class="row-btn btn" type="button" appStopClick - appBlurClick appA11yTitle="{{ 'deleteAttachment' | i18n }}" (click)="delete(a)" #deleteBtn diff --git a/apps/browser/src/popup/vault/ciphers.component.html b/apps/browser/src/popup/vault/ciphers.component.html index d6b87568663..340e7db8dd4 100644 --- a/apps/browser/src/popup/vault/ciphers.component.html +++ b/apps/browser/src/popup/vault/ciphers.component.html @@ -1,6 +1,6 @@
- @@ -19,7 +19,7 @@
-
@@ -40,7 +40,6 @@ *ngFor="let f of nestedFolders" class="box-content-row" appStopClick - appBlurClick (click)="selectFolder(f.node)" >
@@ -63,7 +62,6 @@ *ngFor="let c of nestedCollections" class="box-content-row" appStopClick - appBlurClick (click)="selectCollection(c.node)" >
diff --git a/apps/browser/src/popup/vault/collections.component.html b/apps/browser/src/popup/vault/collections.component.html index 35d7b082610..d8bcf9a0292 100644 --- a/apps/browser/src/popup/vault/collections.component.html +++ b/apps/browser/src/popup/vault/collections.component.html @@ -1,7 +1,7 @@
- @@ -10,7 +10,7 @@ {{ "collections" | i18n }}

- diff --git a/apps/browser/src/popup/vault/current-tab.component.html b/apps/browser/src/popup/vault/current-tab.component.html index f4cfd9f4bc1..c1029abffb3 100644 --- a/apps/browser/src/popup/vault/current-tab.component.html +++ b/apps/browser/src/popup/vault/current-tab.component.html @@ -4,7 +4,6 @@
-
diff --git a/apps/browser/src/popup/vault/password-history.component.html b/apps/browser/src/popup/vault/password-history.component.html index 009b7089baa..73a28bb2520 100644 --- a/apps/browser/src/popup/vault/password-history.component.html +++ b/apps/browser/src/popup/vault/password-history.component.html @@ -1,6 +1,6 @@
- +

{{ "passwordHistory" | i18n }} diff --git a/apps/browser/src/popup/vault/share.component.html b/apps/browser/src/popup/vault/share.component.html index 7e6d6e38af3..ad1447f6f65 100644 --- a/apps/browser/src/popup/vault/share.component.html +++ b/apps/browser/src/popup/vault/share.component.html @@ -1,7 +1,7 @@
- +

{{ "moveToOrganization" | i18n }} @@ -9,7 +9,6 @@
-
@@ -61,7 +61,6 @@ type="button" class="box-content-row" appStopClick - appBlurClick (click)="selectType(cipherType.Login)" >
@@ -75,7 +74,6 @@ type="button" class="box-content-row" appStopClick - appBlurClick (click)="selectType(cipherType.Card)" >
@@ -89,7 +87,6 @@ type="button" class="box-content-row" appStopClick - appBlurClick (click)="selectType(cipherType.Identity)" >
@@ -103,7 +100,6 @@ type="button" class="box-content-row" appStopClick - appBlurClick (click)="selectType(cipherType.SecureNote)" >
@@ -126,7 +122,6 @@ *ngFor="let f of nestedFolders" class="box-content-row" appStopClick - appBlurClick (click)="selectFolder(f.node)" >
@@ -151,7 +146,6 @@ *ngFor="let nestedCollection of nestedCollections" class="box-content-row" appStopClick - appBlurClick (click)="selectCollection(nestedCollection.node)" >
@@ -187,13 +181,7 @@ {{ deletedCount }}

- +

{{ "viewItem" | i18n }}

-
@@ -79,7 +79,6 @@ type="button" #checkPasswordBtn class="row-btn btn" - appBlurClick appA11yTitle="{{ 'checkPassword' | i18n }}" (click)="checkPassword()" [appApiAction]="checkPasswordPromise" @@ -397,7 +396,6 @@ class="box-content-row box-content-row-flex text-default" *ngFor="let attachment of cipher.attachments" appStopClick - appBlurCLick (click)="downloadAttachment(attachment)" > {{ attachment.fileName }} @@ -421,7 +419,6 @@ type="button" class="box-content-row" appStopClick - appBlurClick (click)="fillCipher()" *ngIf="cipher.type !== cipherType.SecureNote && !cipher.isDeleted && !inPopout" > @@ -436,7 +433,6 @@ type="button" class="box-content-row" appStopClick - appBlurClick (click)="fillCipherAndSave()" *ngIf="cipher.type === cipherType.Login && !cipher.isDeleted && !inPopout" > @@ -451,7 +447,6 @@ type="button" class="box-content-row" appStopClick - appBlurClick (click)="clone()" *ngIf="!cipher.organizationId && !cipher.isDeleted" > @@ -466,7 +461,6 @@ type="button" class="box-content-row" appStopClick - appBlurClick (click)="share()" *ngIf="!cipher.organizationId" > @@ -481,7 +475,6 @@ type="button" class="box-content-row" appStopClick - appBlurClick (click)="restore()" *ngIf="cipher.isDeleted" > @@ -492,7 +485,7 @@ {{ "restoreItem" | i18n }}

- diff --git a/apps/desktop/src/app/accounts/set-password.component.html b/apps/desktop/src/app/accounts/set-password.component.html index 0e51f5f2774..340a4701c04 100644 --- a/apps/desktop/src/app/accounts/set-password.component.html +++ b/apps/desktop/src/app/accounts/set-password.component.html @@ -147,7 +147,7 @@ > {{ "submit" | i18n }} - diff --git a/apps/desktop/src/app/components/set-pin.component.html b/apps/desktop/src/app/components/set-pin.component.html index 5bd50bbc352..4c23ad3dde2 100644 --- a/apps/desktop/src/app/components/set-pin.component.html +++ b/apps/desktop/src/app/components/set-pin.component.html @@ -53,7 +53,7 @@