From 2e1cd127c7124317c543340fb66d3f274a6108fb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=9C=A8=20Audrey=20=E2=9C=A8?= Date: Fri, 27 Sep 2024 10:58:01 -0400 Subject: [PATCH 1/4] use revised configuration name when generating send passwords (#11290) --- .../src/send-form/components/options/send-options.component.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/tools/send/send-ui/src/send-form/components/options/send-options.component.ts b/libs/tools/send/send-ui/src/send-form/components/options/send-options.component.ts index 4f95a6bceec..2261ca7e1fa 100644 --- a/libs/tools/send/send-ui/src/send-form/components/options/send-options.component.ts +++ b/libs/tools/send/send-ui/src/send-form/components/options/send-options.component.ts @@ -102,7 +102,7 @@ export class SendOptionsComponent implements OnInit { generatePassword = async () => { const generatedCredential = await firstValueFrom( - this.generatorService.generate$(Generators.Password), + this.generatorService.generate$(Generators.password), ); this.sendOptionsForm.patchValue({ From b149c86c28d8af0b6094a1e0cda86588c149a006 Mon Sep 17 00:00:00 2001 From: cyprain-okeke <108260115+cyprain-okeke@users.noreply.github.com> Date: Fri, 27 Sep 2024 17:51:43 +0100 Subject: [PATCH 2/4] Resolve the issue of recalculation (#11294) --- .../app/billing/organizations/change-plan-dialog.component.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/web/src/app/billing/organizations/change-plan-dialog.component.ts b/apps/web/src/app/billing/organizations/change-plan-dialog.component.ts index 42a987664f0..c7cd7e45a9e 100644 --- a/apps/web/src/app/billing/organizations/change-plan-dialog.component.ts +++ b/apps/web/src/app/billing/organizations/change-plan-dialog.component.ts @@ -497,7 +497,7 @@ export class ChangePlanDialogComponent implements OnInit, OnDestroy { return 0; } - const result = plan.PasswordManager.seatPrice * Math.abs(this.organization.seats || 0); + const result = plan.PasswordManager.seatPrice * Math.abs(this.sub?.seats || 0); return result; } From 20c253e87b6ab437e663da0d3e044c88b18ab926 Mon Sep 17 00:00:00 2001 From: Daniel James Smith <2670567+djsmith85@users.noreply.github.com> Date: Fri, 27 Sep 2024 19:03:22 +0200 Subject: [PATCH 3/4] [PM-12066] Add missing column headers to reports (#11293) * Add missing column header to weak-password report * Add missing column header to exposed-password report * Add missing column header to reused-password report --------- Co-authored-by: Daniel James Smith --- .../pages/exposed-passwords-report.component.html | 4 +++- .../reports/pages/reused-passwords-report.component.html | 2 +- .../reports/pages/weak-passwords-report.component.html | 4 +++- apps/web/src/locales/en/messages.json | 9 +++++++++ 4 files changed, 16 insertions(+), 3 deletions(-) diff --git a/apps/web/src/app/tools/reports/pages/exposed-passwords-report.component.html b/apps/web/src/app/tools/reports/pages/exposed-passwords-report.component.html index bcd5a28812a..b3f2ae581b3 100644 --- a/apps/web/src/app/tools/reports/pages/exposed-passwords-report.component.html +++ b/apps/web/src/app/tools/reports/pages/exposed-passwords-report.component.html @@ -34,7 +34,9 @@ {{ "owner" | i18n }} - + + {{ "timesExposed" | i18n }} + diff --git a/apps/web/src/app/tools/reports/pages/reused-passwords-report.component.html b/apps/web/src/app/tools/reports/pages/reused-passwords-report.component.html index e836c14996f..af336c94854 100644 --- a/apps/web/src/app/tools/reports/pages/reused-passwords-report.component.html +++ b/apps/web/src/app/tools/reports/pages/reused-passwords-report.component.html @@ -39,7 +39,7 @@ {{ "name" | i18n }} {{ "owner" | i18n }} - + {{ "timesReused" | i18n }} diff --git a/apps/web/src/app/tools/reports/pages/weak-passwords-report.component.html b/apps/web/src/app/tools/reports/pages/weak-passwords-report.component.html index e5e5245575d..4ee0e2986bd 100644 --- a/apps/web/src/app/tools/reports/pages/weak-passwords-report.component.html +++ b/apps/web/src/app/tools/reports/pages/weak-passwords-report.component.html @@ -39,7 +39,9 @@ {{ "owner" | i18n }} - + + {{ "weakness" | i18n }} + diff --git a/apps/web/src/locales/en/messages.json b/apps/web/src/locales/en/messages.json index ed3bc14c254..63dbd6ff9ce 100644 --- a/apps/web/src/locales/en/messages.json +++ b/apps/web/src/locales/en/messages.json @@ -2199,6 +2199,9 @@ "checkExposedPasswords": { "message": "Check exposed passwords" }, + "timesExposed": { + "message": "Times exposed" + }, "exposedXTimes": { "message": "Exposed $COUNT$ time(s)", "placeholders": { @@ -2233,6 +2236,9 @@ "noWeakPasswords": { "message": "No items in your vault have weak passwords." }, + "weakness": { + "message": "Weakness" + }, "reusedPasswordsReport": { "message": "Reused passwords" }, @@ -2258,6 +2264,9 @@ "noReusedPasswords": { "message": "No logins in your vault have passwords that are being reused." }, + "timesReused": { + "message": "Times reused" + }, "reusedXTimes": { "message": "Reused $COUNT$ times", "placeholders": { From 08e9a69083e5d14cfb5a01f8cecbb22c595c315e Mon Sep 17 00:00:00 2001 From: Jordan Aasen <166539328+jaasen-livefront@users.noreply.github.com> Date: Fri, 27 Sep 2024 10:56:17 -0700 Subject: [PATCH 4/4] fix delete send button (#11296) --- .../tools/popup/send-v2/add-edit/send-add-edit.component.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/browser/src/tools/popup/send-v2/add-edit/send-add-edit.component.html b/apps/browser/src/tools/popup/send-v2/add-edit/send-add-edit.component.html index e96a0742a03..b3783bfed3a 100644 --- a/apps/browser/src/tools/popup/send-v2/add-edit/send-add-edit.component.html +++ b/apps/browser/src/tools/popup/send-v2/add-edit/send-add-edit.component.html @@ -19,7 +19,7 @@ *ngIf="config?.mode !== 'add'" type="button" buttonType="danger" - class="tw-ml-auto bwi-lg" + slot="end" bitIconButton="bwi-trash" [bitAction]="deleteSend" appA11yTitle="{{ 'delete' | i18n }}"