From 071aec2556c42e17704543e6d81b442afeda7ce7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E2=9C=A8=20Audrey=20=E2=9C=A8?= Date: Mon, 24 Mar 2025 11:28:05 -0400 Subject: [PATCH] fix broken tests --- .../core/src/services/generator-metadata-provider.spec.ts | 4 ++-- .../core/src/services/generator-metadata-provider.ts | 2 +- libs/tools/generator/core/src/types/metadata-request.ts | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libs/tools/generator/core/src/services/generator-metadata-provider.spec.ts b/libs/tools/generator/core/src/services/generator-metadata-provider.spec.ts index 8e765adf005..958e5608449 100644 --- a/libs/tools/generator/core/src/services/generator-metadata-provider.spec.ts +++ b/libs/tools/generator/core/src/services/generator-metadata-provider.spec.ts @@ -285,7 +285,7 @@ describe("GeneratorMetadataProvider", () => { const provider = new GeneratorMetadataProvider(SystemProvider, ApplicationProvider, []); // `any` cast required because this test subverts the type system - expect(() => provider.algorithms({} as any)).toThrow("algorithm or category required"); + expect(() => provider.algorithms({} as any)).toThrow("algorithm or type required"); }); }); @@ -369,7 +369,7 @@ describe("GeneratorMetadataProvider", () => { const provider = new GeneratorMetadataProvider(SystemProvider, ApplicationProvider, []); expect(() => provider.algorithms$({} as any, { account$: SomeAccount$ })).toThrow( - "algorithm or category required", + "algorithm or type required", ); }); }); diff --git a/libs/tools/generator/core/src/services/generator-metadata-provider.ts b/libs/tools/generator/core/src/services/generator-metadata-provider.ts index a048ddd0274..125ee62a01a 100644 --- a/libs/tools/generator/core/src/services/generator-metadata-provider.ts +++ b/libs/tools/generator/core/src/services/generator-metadata-provider.ts @@ -215,7 +215,7 @@ export class GeneratorMetadataProvider { return algorithm; } - const algorithms = this.algorithms({ type: type }); + const algorithms = type ? this.algorithms({ type: type }) : []; // `?? null` because logging types must be `Jsonify` const defaultAlgorithm = algorithms.find(isAvailable) ?? null; this.log.debug( diff --git a/libs/tools/generator/core/src/types/metadata-request.ts b/libs/tools/generator/core/src/types/metadata-request.ts index 686bb95db4f..e9cae7060f0 100644 --- a/libs/tools/generator/core/src/types/metadata-request.ts +++ b/libs/tools/generator/core/src/types/metadata-request.ts @@ -9,5 +9,5 @@ export function isAlgorithmRequest(request: MetadataRequest): request is Algorit } export function isTypeRequest(request: MetadataRequest): request is TypeRequest { - return !!request.algorithm; + return !!request.type; }