bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-06 00:13:28 +00:00
Code Issues Releases Wiki Activity

[PM-4239] When viewing an item with a passkey, passkey is not announced by screenreader (#7154)

Browse Source 
* Made passkey field focusable

* Made passkey field focusableand accessibilty possible for screenreaders in announcing the field
This commit is contained in:
SmithThe4th
2023-12-21 10:54:54 -05:00
committed by GitHub
parent 6fe82e95e7
commit 07d224d6bc
12 changed files with 66 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
libs/angular/src/vault/components/add-edit.component.ts
View File

@@ -1,3 +1,4 @@
import { DatePipe } from "@angular/common";
import { Directive, EventEmitter, Input, OnDestroy, OnInit, Output } from "@angular/core";
import { Observable, Subject, takeUntil, concatMap } from "rxjs";
@@ -85,6 +86,15 @@ export class AddEditComponent implements OnInit, OnDestroy {
private personalOwnershipPolicyAppliesToActiveUser: boolean;
private previousCipherId: string;
get fido2CredentialCreationDateValue(): string {
const dateCreated = this.i18nService.t("dateCreated");
const creationDate = this.datePipe.transform(
this.cipher?.login?.fido2Credentials?.[0]?.creationDate,
"short",
);
return `${dateCreated} ${creationDate}`;
}
constructor(
protected cipherService: CipherService,
protected folderService: FolderService,
@@ -101,6 +111,7 @@ export class AddEditComponent implements OnInit, OnDestroy {
private organizationService: OrganizationService,
protected sendApiService: SendApiService,
protected dialogService: DialogService,
protected datePipe: DatePipe,
) {
this.typeOptions = [
{ name: i18nService.t("typeLogin"), value: CipherType.Login },

11
libs/angular/src/vault/components/view.component.ts
View File

@@ -1,3 +1,4 @@
import { DatePipe } from "@angular/common";
import {
ChangeDetectorRef,
Directive,
@@ -68,6 +69,15 @@ export class ViewComponent implements OnDestroy, OnInit {
private previousCipherId: string;
private passwordReprompted = false;
get fido2CredentialCreationDateValue(): string {
const dateCreated = this.i18nService.t("dateCreated");
const creationDate = this.datePipe.transform(
this.cipher?.login?.fido2Credentials?.[0]?.creationDate,
"short",
);
return `${dateCreated} ${creationDate}`;
}
constructor(
protected cipherService: CipherService,
protected folderService: FolderService,
@@ -88,6 +98,7 @@ export class ViewComponent implements OnDestroy, OnInit {
protected stateService: StateService,
protected fileDownloadService: FileDownloadService,
protected dialogService: DialogService,
protected datePipe: DatePipe,
) {}
ngOnInit() {