1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-06 00:13:28 +00:00

[PM-27757] init new apps state (#17200)

* feat(dirt): add "needs review" state for applications needing initial review

- Add showNeedsReviewState to display warning when all apps lack review dates
- Track noAppsHaveReviewDate flag to identify unreviewed applications
- Add i18n strings for organization items count and review prompt
- Update activity card to show 3 states: all caught up, needs review, new apps
- Apply tw-col-span-2 to needs review card for better visibility

* refactor: split activity card states into separate @if blocks for readability

* fix: set hasLoadedApplicationData when summary data arrives

Previously, hasLoadedApplicationData was only set in the enrichedReportData$
subscription, which fired after reportSummary$ and newApplications$. This
caused a timing issue where showNeedsReviewState would remain false even when
newApplicationsCount === totalApplicationCount because the flag wasn't set yet.

Now we set hasLoadedApplicationData=true as soon as reportSummary$ arrives
with totalApplicationCount > 0, ensuring proper synchronization.

---------

Co-authored-by: Tom <ttalty@bitwarden.com>
This commit is contained in:
Alex
2025-11-11 13:11:33 -05:00
committed by GitHub
parent b05abdb99c
commit 089caf57c2
3 changed files with 86 additions and 21 deletions

View File

@@ -373,6 +373,21 @@
"noNewApplicationsToReviewAtThisTime": {
"message": "No new applications to review at this time"
},
"organizationHasItemsSavedForApplications": {
"message": "Your organization has items saved for $COUNT$ applications",
"placeholders": {
"count": {
"content": "$1",
"example": "310"
}
}
},
"reviewApplicationsToSecureItems": {
"message": "Review applications to secure the items most critical to your organization's security"
},
"reviewApplications": {
"message": "Review applications"
},
"prioritizeCriticalApplications": {
"message": "Prioritize critical applications"
},