bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-17 08:43:33 +00:00
Code Issues Releases Wiki Activity

fixed pr comments

Browse Source
This commit is contained in:
gbubemismith
2023-08-30 12:56:28 -04:00
parent 7becb305fe
commit 08c6a302b2
2 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
apps/browser/src/services/fido2/browser-fido2-user-interface.service.ts
View File

@@ -195,8 +195,8 @@ export class BrowserFido2UserInterfaceSession implements Fido2UserInterfaceSessi
); );
this.tabClosed$ = fromEventPattern( this.tabClosed$ = fromEventPattern(
(handler: any) => chrome.windows.onRemoved.addListener(handler), (handler: any) => chrome.tabs.onRemoved.addListener(handler),
(handler: any) => chrome.windows.onRemoved.removeListener(handler) (handler: any) => chrome.tabs.onRemoved.removeListener(handler)
); );
BrowserFido2UserInterfaceSession.sendMessage({ BrowserFido2UserInterfaceSession.sendMessage({
@@ -303,7 +303,7 @@ export class BrowserFido2UserInterfaceSession implements Fido2UserInterfaceSessi
this.destroy$.complete(); this.destroy$.complete();
} }
async abort(fallback = false) { private async abort(fallback = false) {
this.abortController.abort(fallback ? UserRequestedFallbackAbortReason : undefined); this.abortController.abort(fallback ? UserRequestedFallbackAbortReason : undefined);
} }

5
apps/web/src/app/auth/login/login.component.ts
View File

@@ -144,11 +144,6 @@ export class LoginComponent extends BaseLoginComponent implements OnInit {
} }
} }
// eslint-disable-next-line rxjs-angular/prefer-takeuntil
ngOnDestroy(): void {
super.ngOnDestroy();
}
async goAfterLogIn() { async goAfterLogIn() {
const masterPassword = this.formGroup.value.masterPassword; const masterPassword = this.formGroup.value.masterPassword;