fix(enums-eslint): Enum Rule for ESLint (#14650)

* fix(enums-eslint): Enum Rule for ESLint - Added enums in the warnings for eslint.

* fix(enums-eslint): Enum Rule for ESLint - Updated to error in both places for enums.

* fix(enums-eslint): Enum Rule for ESLint - Added new eslint plugin for warning on enums.

* fix(enums-eslint): Enum Rule for ESLint - Changed based on suggestion.

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>

* refactor(browser-platform-utils): Remove Deprecation and Fix Code - Changed usages of firefox to private and moved the usages to the preferred public method and removed the deprecations.

* fix(enums-eslint): Enum Rule for ESLint - Updated to error and added disable rules for all other places.

* fix(enums-eslint): Enum Rule for ESLint - Undid other changes by accident

libs/common/src/auth/enums/auth-request-type.ts

@@ -1,3 +1,5 @@
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum AuthRequestType {
   AuthenticateAndUnlock = 0,
   Unlock = 1,

libs/common/src/auth/enums/authentication-status.ts

@@ -1,3 +1,5 @@
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum AuthenticationStatus {
   LoggedOut = 0,
   Locked = 1,

libs/common/src/auth/enums/authentication-type.ts

@@ -1,3 +1,5 @@
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum AuthenticationType {
   Password = 0,
   Sso = 1,

libs/common/src/auth/enums/sso.ts

@@ -1,25 +1,35 @@
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum SsoType {
   None = 0,
   OpenIdConnect = 1,
   Saml2 = 2,
 }
 
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum MemberDecryptionType {
   MasterPassword = 0,
   KeyConnector = 1,
   TrustedDeviceEncryption = 2,
 }
 
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum OpenIdConnectRedirectBehavior {
   RedirectGet = 0,
   FormPost = 1,
 }
 
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum Saml2BindingType {
   HttpRedirect = 1,
   HttpPost = 2,
 }
 
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum Saml2NameIdFormat {
   NotConfigured = 0,
   Unspecified = 1,
@@ -32,6 +42,8 @@ export enum Saml2NameIdFormat {
   Transient = 8,
 }
 
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum Saml2SigningBehavior {
   IfIdpWantAuthnRequestsSigned = 0,
   Always = 1,

libs/common/src/auth/enums/two-factor-provider-type.ts

@@ -1,3 +1,5 @@
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum TwoFactorProviderType {
   Authenticator = 0,
   Email = 1,

libs/common/src/auth/enums/verification-type.ts

@@ -1,3 +1,5 @@
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum VerificationType {
   MasterPassword = 0,
   OTP = 1,

libs/common/src/auth/models/domain/force-set-password-reason.ts

@@ -2,6 +2,8 @@
  * This enum is used to determine if a user should be forced to initially set or reset their password
  * on login (server flag) or unlock via MP (client evaluation).
  */
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum ForceSetPasswordReason {
   /**
    * A password reset should not be forced.

libs/common/src/auth/services/token.service.ts

@@ -43,6 +43,8 @@ import {
   SECURITY_STAMP_MEMORY,
 } from "./token.state";
 
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum TokenStorageLocation {
   Disk = "disk",
   SecureStorage = "secureStorage",