fix(enums-eslint): Enum Rule for ESLint (#14650)

* fix(enums-eslint): Enum Rule for ESLint - Added enums in the warnings for eslint.

* fix(enums-eslint): Enum Rule for ESLint - Updated to error in both places for enums.

* fix(enums-eslint): Enum Rule for ESLint - Added new eslint plugin for warning on enums.

* fix(enums-eslint): Enum Rule for ESLint - Changed based on suggestion.

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>

* refactor(browser-platform-utils): Remove Deprecation and Fix Code - Changed usages of firefox to private and moved the usages to the preferred public method and removed the deprecations.

* fix(enums-eslint): Enum Rule for ESLint - Updated to error and added disable rules for all other places.

* fix(enums-eslint): Enum Rule for ESLint - Undid other changes by accident

libs/common/src/enums/client-type.enum.ts

@@ -1,3 +1,5 @@
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum ClientType {
   Web = "web",
   Browser = "browser",

libs/common/src/enums/device-type.enum.ts

@@ -1,3 +1,5 @@
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum DeviceType {
   Android = 0,
   iOS = 1,

libs/common/src/enums/event-system-user.enum.ts

@@ -1,4 +1,6 @@
 // Note: the enum key is used to describe the EventSystemUser in the UI. Be careful about changing it.
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum EventSystemUser {
   SCIM = 1,
   DomainVerification = 2,

libs/common/src/enums/event-type.enum.ts

@@ -1,4 +1,6 @@
 // Increment by 100 for each new set of events
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum EventType {
   User_LoggedIn = 1000,
   User_ChangedPassword = 1001,

libs/common/src/enums/feature-flag.enum.ts

@@ -7,6 +7,8 @@ import { ServerConfig } from "../platform/abstractions/config/server-config";
  *
  * Flags should be grouped by team to have visibility of ownership and cleanup.
  */
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum FeatureFlag {
   /* Admin Console Team */
   VerifiedSsoDomainEndpoint = "pm-12337-refactor-sso-details-endpoint",

libs/common/src/enums/http-status-code.enum.ts

@@ -4,6 +4,8 @@
  * @see {@link https://en.wikipedia.org/wiki/List_of_HTTP_status_codes}
  * src: https://gist.github.com/RWOverdijk/6cef816cfdf5722228e01cc05fd4b094
  */
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum HttpStatusCode {
   /**
    * The server has received the request headers and the client should proceed to send the request body

libs/common/src/enums/integration-type.enum.ts

@@ -1,3 +1,5 @@
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum IntegrationType {
   Integration = "integration",
   SDK = "sdk",

libs/common/src/enums/native-messaging-version.enum.ts

@@ -1,3 +1,5 @@
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum NativeMessagingVersion {
   One = 1, // Original implementation
   Latest = One,

libs/common/src/enums/notification-type.enum.ts

@@ -1,3 +1,5 @@
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum NotificationType {
   SyncCipherUpdate = 0,
   SyncCipherCreate = 1,

libs/common/src/enums/push-technology.enum.ts

@@ -1,6 +1,8 @@
 /**
  * The preferred push technology of the server.
  */
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum PushTechnology {
   /**
    * Indicates that we should use SignalR over web sockets to receive push notifications from the server.