fix(enums-eslint): Enum Rule for ESLint (#14650)

* fix(enums-eslint): Enum Rule for ESLint - Added enums in the warnings for eslint.

* fix(enums-eslint): Enum Rule for ESLint - Updated to error in both places for enums.

* fix(enums-eslint): Enum Rule for ESLint - Added new eslint plugin for warning on enums.

* fix(enums-eslint): Enum Rule for ESLint - Changed based on suggestion.

Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>

* refactor(browser-platform-utils): Remove Deprecation and Fix Code - Changed usages of firefox to private and moved the usages to the preferred public method and removed the deprecations.

* fix(enums-eslint): Enum Rule for ESLint - Updated to error and added disable rules for all other places.

* fix(enums-eslint): Enum Rule for ESLint - Undid other changes by accident

libs/common/src/platform/abstractions/environment.service.ts

@@ -17,6 +17,8 @@ export type Urls = {
 /**
  * A subset of available regions, additional regions can be loaded through configuration.
  */
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum Region {
   US = "US",
   EU = "EU",

libs/common/src/platform/abstractions/fido2/fido2-authenticator.service.abstraction.ts

@@ -46,11 +46,15 @@ export abstract class Fido2AuthenticatorService<ParentWindowReference> {
   silentCredentialDiscovery: (rpId: string) => Promise<Fido2CredentialView[]>;
 }
 
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum Fido2AlgorithmIdentifier {
   ES256 = -7,
   RS256 = -257,
 }
 
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum Fido2AuthenticatorErrorCode {
   Unknown = "UnknownError",
   NotSupported = "NotSupportedError",

libs/common/src/platform/enums/encryption-type.enum.ts

@@ -1,3 +1,5 @@
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum EncryptionType {
   AesCbc256_B64 = 0,
   // Type 1 was the unused and removed AesCbc128_HmacSha256_B64

libs/common/src/platform/enums/file-upload-type.enum.ts

@@ -1,3 +1,5 @@
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum FileUploadType {
   Direct = 0,
   Azure = 1,

libs/common/src/platform/enums/hash-purpose.enum.ts

@@ -1,3 +1,5 @@
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum HashPurpose {
   ServerAuthorization = 1,
   LocalAuthorization = 2,

libs/common/src/platform/enums/html-storage-location.enum.ts

@@ -1,3 +1,5 @@
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum HtmlStorageLocation {
   Local = "local",
   Memory = "memory",

libs/common/src/platform/enums/key-suffix-options.enum.ts

@@ -1,3 +1,5 @@
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum KeySuffixOptions {
   Auto = "auto",
   Pin = "pin",

libs/common/src/platform/enums/log-level-type.enum.ts

@@ -1,3 +1,5 @@
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum LogLevelType {
   Debug,
   Info,

libs/common/src/platform/enums/storage-location.enum.ts

@@ -1,3 +1,5 @@
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum StorageLocation {
   Both = "both",
   Disk = "disk",

libs/common/src/platform/enums/theme-type.enum.ts

@@ -1,6 +1,8 @@
 /**
  * @deprecated prefer the `ThemeTypes` constants and `Theme` type over unsafe enum types
  **/
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum ThemeType {
   System = "system",
   Light = "light",

libs/common/src/platform/services/cryptography/initializer-key.ts

@@ -1,3 +1,5 @@
+// FIXME: update to use a const object instead of a typescript enum
+// eslint-disable-next-line @bitwarden/platform/no-enums
 export enum InitializerKey {
   Cipher = 0,
   CipherView = 1,