bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-15 07:43:35 +00:00
Code Issues Releases Wiki Activity

[PM-8027] Fixing an issue where a field that has no form and no visible password fields should be qualified if a single password field exists in the page

Browse Source
This commit is contained in:
Cesar Gonzalez
2024-06-13 14:16:28 -05:00
parent f2289f2b21
commit 0b9af06945
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
apps/browser/src/autofill/services/inline-menu-field-qualification.service.ts
View File

@@ -167,6 +167,12 @@ export class InlineMenuFieldQualificationService
return false; return false;
} }
// If no visible fields are found on the page, but we have a single password
// field we should assume that the field is part of a login form.
if (passwordFieldsInPageDetails.length === 1) {
return true;
}
// If the page does not contain any password fields, it might be part of a multistep login form. // If the page does not contain any password fields, it might be part of a multistep login form.
// That will only be the case if the field does not explicitly have its autocomplete attribute // That will only be the case if the field does not explicitly have its autocomplete attribute
// set to "off" or "false". // set to "off" or "false".