1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-16 16:23:44 +00:00

Move share from edit to view. Fix animations (#1497)

* Move share from edit to view. Fix animations

Editing and Sharing a cipher simultaneously results in lost edits. Move
share button to the view page to resolve this confusion.

Previous routing caused the share form to be animated again on
submition, resulting in a stuttering page load. This method correctly
animates all transitions with the concession that the share page
always takes you back to the view page. This is not necessarily the current
behavior, but it is the most likely behavior in the current scheme

* Update jslib reference
This commit is contained in:
Matt Gibson
2020-12-17 11:06:31 -06:00
committed by GitHub
parent db4b1b63b9
commit 0cd6efd67f
8 changed files with 22 additions and 24 deletions

View File

@@ -43,7 +43,7 @@ export class ActionButtonsComponent {
async ngOnInit() {
this.userHasPremiumAccess = await this.userService.canAccessPremium();
}
launch() {
if (this.cipher.type !== CipherType.Login || !this.cipher.login.canLaunch) {
return;