bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-11 13:53:34 +00:00
Code Issues Releases Wiki Activity

[PM-23813] apply dismiss check when setting status inside nudge services addressing footer lag in FF. (#15639)

Browse Source
This commit is contained in:
Jason Ng
2025-07-16 15:32:06 -04:00
committed by GitHub
parent 2086e7ae87
commit 0cebdd4581
3 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
libs/angular/src/vault/services/custom-nudges-services/account-security-nudge.service.ts
View File

@@ -74,7 +74,10 @@ export class AccountSecurityNudgeService extends DefaultSingleNudgeService {
hasSpotlightDismissed: status.hasSpotlightDismissed || hideNudge, hasSpotlightDismissed: status.hasSpotlightDismissed || hideNudge,
}; };
if (isPinSet || biometricUnlockEnabled || hasOrgWithRemovePinPolicyOn) { if (
(isPinSet || biometricUnlockEnabled || hasOrgWithRemovePinPolicyOn) &&
!status.hasSpotlightDismissed
) {
await this.setNudgeStatus(nudgeType, acctSecurityNudgeStatus, userId); await this.setNudgeStatus(nudgeType, acctSecurityNudgeStatus, userId);
} }
return acctSecurityNudgeStatus; return acctSecurityNudgeStatus;

6
libs/angular/src/vault/services/custom-nudges-services/has-items-nudge.service.ts
View File

@@ -44,7 +44,11 @@ export class HasItemsNudgeService extends DefaultSingleNudgeService {
return cipher.deletedDate == null; return cipher.deletedDate == null;
}); });
if (profileOlderThanCutoff && filteredCiphers.length > 0) { if (
profileOlderThanCutoff &&
filteredCiphers.length > 0 &&
!nudgeStatus.hasSpotlightDismissed
) {
const dismissedStatus = { const dismissedStatus = {
hasSpotlightDismissed: true, hasSpotlightDismissed: true,
hasBadgeDismissed: true, hasBadgeDismissed: true,

2
libs/angular/src/vault/services/custom-nudges-services/new-item-nudge.service.ts
View File

@@ -49,7 +49,7 @@ export class NewItemNudgeService extends DefaultSingleNudgeService {
const ciphersBoolean = ciphers.some((cipher) => cipher.type === currentType); const ciphersBoolean = ciphers.some((cipher) => cipher.type === currentType);
if (ciphersBoolean) { if (ciphersBoolean && !nudgeStatus.hasSpotlightDismissed) {
const dismissedStatus = { const dismissedStatus = {
hasSpotlightDismissed: true, hasSpotlightDismissed: true,
hasBadgeDismissed: true, hasBadgeDismissed: true,