bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-12 22:33:35 +00:00
Code Issues Releases Wiki Activity

user decryption parsing error bug (#16346)

Browse Source
This commit is contained in:
Maciej Zieniuk
2025-09-08 22:56:22 +02:00
committed by GitHub
parent c017e3c676
commit 0d6a67fc81
2 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
libs/common/src/key-management/models/response/user-decryption.response.spec.ts
View File

@@ -35,9 +35,14 @@ describe("UserDecryptionResponse", () => {
);
});
it("should create response when masterPasswordUnlock is not provided", () => {
const userDecryptionResponse = new UserDecryptionResponse({});
it.each([null, undefined, "should be object type"])(
"should create response when masterPasswordUnlock is %s",
(masterPasswordUnlock) => {
const userDecryptionResponse = new UserDecryptionResponse({
MasterPasswordUnlock: masterPasswordUnlock,
});
expect(userDecryptionResponse.masterPasswordUnlock).toBeUndefined();
});
expect(userDecryptionResponse.masterPasswordUnlock).toBeUndefined();
},
);
});

2
libs/common/src/key-management/models/response/user-decryption.response.ts
View File

@@ -8,7 +8,7 @@ export class UserDecryptionResponse extends BaseResponse {
super(response);
const masterPasswordUnlock = this.getResponseProperty("MasterPasswordUnlock");
if (masterPasswordUnlock != null || typeof masterPasswordUnlock === "object") {
if (masterPasswordUnlock != null && typeof masterPasswordUnlock === "object") {
this.masterPasswordUnlock = new MasterPasswordUnlockResponse(masterPasswordUnlock);
}
}