bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-11 13:53:34 +00:00
Code Issues Releases Wiki Activity

Display inline autofill on Gap.com password field (#16085)

Browse Source
This commit is contained in:
Jeffrey Holland
2025-10-06 09:50:49 +02:00
committed by GitHub
parent 96841129e6
commit 0daecf4a77
1 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
apps/browser/src/autofill/services/collect-autofill-content.service.ts
View File

@@ -433,7 +433,6 @@ export class CollectAutofillContentService implements CollectAutofillContentServ
/** /**
* Caches the autofill field element and its data. * Caches the autofill field element and its data.
* Will not cache the element if the index is less than 0.
* *
* @param index - The index of the autofill field element * @param index - The index of the autofill field element
* @param element - The autofill field element to cache * @param element - The autofill field element to cache
@@ -444,10 +443,7 @@ export class CollectAutofillContentService implements CollectAutofillContentServ
element: ElementWithOpId<FormFieldElement>, element: ElementWithOpId<FormFieldElement>,
autofillFieldData: AutofillField, autofillFieldData: AutofillField,
) { ) {
if (index < 0) { // Always cache the element, even if index is -1 (for dynamically added fields)
return;
}
this.autofillFieldElements.set(element, autofillFieldData); this.autofillFieldElements.set(element, autofillFieldData);
} }
@@ -1196,7 +1192,7 @@ export class CollectAutofillContentService implements CollectAutofillContentServ
private setupOverlayListenersOnMutatedElements(mutatedElements: Node[]) { private setupOverlayListenersOnMutatedElements(mutatedElements: Node[]) {
for (let elementIndex = 0; elementIndex < mutatedElements.length; elementIndex++) { for (let elementIndex = 0; elementIndex < mutatedElements.length; elementIndex++) {
const node = mutatedElements[elementIndex]; const node = mutatedElements[elementIndex];
const buildAutofillFieldItem = () => { const buildAutofillFieldItem = async () => {
if ( if (
!this.isNodeFormFieldElement(node) || !this.isNodeFormFieldElement(node) ||
this.autofillFieldElements.get(node as ElementWithOpId<FormFieldElement>) this.autofillFieldElements.get(node as ElementWithOpId<FormFieldElement>)
@@ -1206,7 +1202,17 @@ export class CollectAutofillContentService implements CollectAutofillContentServ
// We are setting this item to a -1 index because we do not know its position in the DOM. // We are setting this item to a -1 index because we do not know its position in the DOM.
// This value should be updated with the next call to collect page details. // This value should be updated with the next call to collect page details.
void this.buildAutofillFieldItem(node as ElementWithOpId<FormFieldElement>, -1); const formFieldElement = node as ElementWithOpId<FormFieldElement>;
const autofillField = await this.buildAutofillFieldItem(formFieldElement, -1);
// Set up overlay listeners for the new field if we have the overlay service
if (autofillField && this.autofillOverlayContentService) {
this.setupOverlayOnField(formFieldElement, autofillField);
if (this.domRecentlyMutated) {
this.updateAutofillElementsAfterMutation();
}
}
}; };
requestIdleCallbackPolyfill(buildAutofillFieldItem, { timeout: 1000 }); requestIdleCallbackPolyfill(buildAutofillFieldItem, { timeout: 1000 });