bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-21 02:33:46 +00:00
Code Issues Releases Wiki Activity

Use logService for console messages (#214)

Browse Source 
* Use logService for console messages

* linter autofixes

* Use full import path

* Implement a base ConsoleLog service

Use this class as a default for other services that would like to output
to console. This service is overriden in CLI and Desktop to use CLI's
consoleLogService and electronLogService, respectively.

* linter fixes

Co-authored-by: Matt Gibson <mdgibson@Matts-MBP.lan>
This commit is contained in:
Matt Gibson
2020-12-04 12:38:26 -06:00
committed by GitHub
parent 6fb0646481
commit 0fed528b6f
10 changed files with 141 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/services/notifications.service.ts
View File

@@ -6,10 +6,12 @@ import { NotificationType } from '../enums/notificationType';
import { ApiService } from '../abstractions/api.service';
import { AppIdService } from '../abstractions/appId.service';
import { EnvironmentService } from '../abstractions/environment.service';
import { LogService } from '../abstractions/log.service'
import { NotificationsService as NotificationsServiceAbstraction } from '../abstractions/notifications.service';
import { SyncService } from '../abstractions/sync.service';
import { UserService } from '../abstractions/user.service';
import { VaultTimeoutService } from '../abstractions/vaultTimeout.service';
import { ConsoleLogService } from '../services/consoleLog.service';
import {
NotificationResponse,
@@ -27,7 +29,12 @@ export class NotificationsService implements NotificationsServiceAbstraction {
constructor(private userService: UserService, private syncService: SyncService,
private appIdService: AppIdService, private apiService: ApiService,
private vaultTimeoutService: VaultTimeoutService, private logoutCallback: () => Promise<void>) { }
private vaultTimeoutService: VaultTimeoutService,
private logoutCallback: () => Promise<void>, private logService?: LogService) {
if (!logService) {
this.logService = new ConsoleLogService(false);
}
}
async init(environmentService: EnvironmentService): Promise<void> {
this.inited = false;
@@ -87,8 +94,7 @@ export class NotificationsService implements NotificationsServiceAbstraction {
await this.signalrConnection.stop();
}
} catch (e) {
// tslint:disable-next-line
console.error(e.toString());
this.logService.error(e.toString())
}
}