bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-01-01 08:03:20 +00:00
Code Issues Releases Wiki Activity

[CL-717][PM-27966] Update to Angular 20 and Storybook 9 (#17638)

Browse Source
This commit is contained in:
Vicki League
2025-12-01 14:15:58 -05:00
committed by GitHub
parent 79d518fcf7
commit 10424e227b
101 changed files with 2926 additions and 3531 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libs/components/src/select/select.component.ts
View File

@@ -158,7 +158,9 @@ export class SelectComponent<T> implements BitFormFieldControl, ControlValueAcce
}
set ariaDescribedBy(value: string | undefined) {
this._ariaDescribedBy = value;
this.select()?.searchInput.nativeElement.setAttribute("aria-describedby", value ?? "");
this.select()
?.searchInput()
.nativeElement.setAttribute("aria-describedby", value ?? "");
}
private _ariaDescribedBy?: string;
@@ -218,7 +220,7 @@ export class SelectComponent<T> implements BitFormFieldControl, ControlValueAcce
* Needs to be arrow function to retain `this` scope.
*/
protected onKeyDown = (event: KeyboardEvent) => {
if (this.select().isOpen && event.key === "Escape" && !hasModifierKey(event)) {
if (this.select().isOpen() && event.key === "Escape" && !hasModifierKey(event)) {
event.stopPropagation();
}

2
libs/components/src/select/select.mdx
View File

@@ -1,4 +1,4 @@
import { Meta, Canvas, Source, Primary, Controls } from "@storybook/addon-docs";
import { Meta, Canvas, Source, Primary, Controls } from "@storybook/addon-docs/blocks";
import * as stories from "./select.stories";