From 021efa2c90be060bb66aec01aefd00068a50abdf Mon Sep 17 00:00:00 2001 From: Andreas Coroiu Date: Tue, 29 Oct 2024 16:00:02 +0100 Subject: [PATCH 1/2] Document `firstValueFrom` not being supported (#11769) --- libs/common/src/platform/abstractions/sdk/sdk.service.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/libs/common/src/platform/abstractions/sdk/sdk.service.ts b/libs/common/src/platform/abstractions/sdk/sdk.service.ts index 5e4e4cb4cbe..04be8a992d0 100644 --- a/libs/common/src/platform/abstractions/sdk/sdk.service.ts +++ b/libs/common/src/platform/abstractions/sdk/sdk.service.ts @@ -20,6 +20,11 @@ export abstract class SdkService { * Retrieve a client initialized for a specific user. * This client can be used for operations that require a user context, such as retrieving ciphers * and operations involving crypto. It can also be used for operations that don't require a user context. + * + * **WARNING:** Do not use `firstValueFrom(userClient$)`! Any operations on the client must be done within the observable. + * The client will be destroyed when the observable is no longer subscribed to. + * Please let platform know if you need a client that is not destroyed when the observable is no longer subscribed to. + * * @param userId */ abstract userClient$(userId: UserId): Observable; From b391c291dfd9682193cbb302db5d4c072c53a625 Mon Sep 17 00:00:00 2001 From: Victoria League Date: Tue, 29 Oct 2024 11:10:29 -0400 Subject: [PATCH 2/2] [CL-475] Use buttons instead of anchors for popup tab navigation (#11643) --- .../popup-tab-navigation.component.html | 56 ++++++++++--------- 1 file changed, 31 insertions(+), 25 deletions(-) diff --git a/apps/browser/src/platform/popup/layout/popup-tab-navigation.component.html b/apps/browser/src/platform/popup/layout/popup-tab-navigation.component.html index 972a60d31ad..a5e08133fe2 100644 --- a/apps/browser/src/platform/popup/layout/popup-tab-navigation.component.html +++ b/apps/browser/src/platform/popup/layout/popup-tab-navigation.component.html @@ -3,30 +3,36 @@