From 158da3500843e2055a57829dcd47cff7c184efdc Mon Sep 17 00:00:00 2001 From: Jared Snider <116684653+JaredSnider-Bitwarden@users.noreply.github.com> Date: Thu, 18 Jul 2024 17:18:49 -0400 Subject: [PATCH] Auth/PM-9873 - Registration with Email Verification - Start Component clean up (#10157) * RegistrationStart - sanitize name input * PM-9873 - Registration Start - per discussion with design, remove autofocus to solve issue w/ email required error showing immediately due to login component mousedown events. * PM-9873 - Restore autofocus for accessibility --- .../registration-start/registration-start.component.html | 3 +-- .../registration-start/registration-start.component.ts | 5 ++++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/libs/auth/src/angular/registration/registration-start/registration-start.component.html b/libs/auth/src/angular/registration/registration-start/registration-start.component.html index 53347258395..d4298504fce 100644 --- a/libs/auth/src/angular/registration/registration-start/registration-start.component.html +++ b/libs/auth/src/angular/registration/registration-start/registration-start.component.html @@ -12,7 +12,6 @@ type="email" formControlName="email" [attr.readonly]="emailReadonly ? true : null" - appAutofocus /> @@ -86,8 +85,8 @@ id="check_your_email_heading" class="tw-font-bold tw-mb-3 tw-text-main" tabindex="0" - appAutofocus aria-describedby="follow_the_link_body" + appAutofocus > {{ "checkYourEmail" | i18n }} diff --git a/libs/auth/src/angular/registration/registration-start/registration-start.component.ts b/libs/auth/src/angular/registration/registration-start/registration-start.component.ts index 00baeb71072..141bff11525 100644 --- a/libs/auth/src/angular/registration/registration-start/registration-start.component.ts +++ b/libs/auth/src/angular/registration/registration-start/registration-start.component.ts @@ -127,9 +127,12 @@ export class RegistrationStartComponent implements OnInit, OnDestroy { return; } + // The app expects null for name and not empty string. + const sanitizedName = this.name.value === "" ? null : this.name.value; + const request: RegisterSendVerificationEmailRequest = new RegisterSendVerificationEmailRequest( this.email.value, - this.name.value, + sanitizedName, this.receiveMarketingEmails.value, );