[PM-8519] Inline Menu fails to Update Credentials After Saving New Cipher When Unlocking Extension

apps/browser/src/autofill/background/abstractions/overlay.background.ts

@@ -76,7 +76,9 @@ type OverlayBackgroundExtensionMessageHandlers = {
   updateFocusedFieldData: ({ message }: BackgroundMessageParam) => void;
   collectPageDetailsResponse: ({ message, sender }: BackgroundOnMessageHandlerParams) => void;
   unlockCompleted: ({ message }: BackgroundMessageParam) => void;
+  addedCipher: () => void;
   addEditCipherSubmitted: () => void;
+  editedCipher: () => void;
   deletedCipher: () => void;
 };
 

apps/browser/src/autofill/background/overlay.background.spec.ts

@@ -961,29 +961,23 @@ describe("OverlayBackground", () => {
         });
       });
 
-      describe("addEditCipherSubmitted message handler", () => {
+      describe("extension messages that trigger an update of the inline menu ciphers", () => {
-        it("updates the overlay ciphers", () => {
+        const extensionMessages = [
-          const message = {
+          "addedCipher",
-            command: "addEditCipherSubmitted",
+          "addEditCipherSubmitted",
-          };
+          "editedCipher",
-          jest.spyOn(overlayBackground as any, "updateOverlayCiphers").mockImplementation();
+          "deletedCipher",
+        ];
 
-          sendExtensionRuntimeMessage(message);
+        beforeEach(() => {
-
+          jest.spyOn(overlayBackground, "updateOverlayCiphers").mockImplementation();
-          expect(overlayBackground["updateOverlayCiphers"]).toHaveBeenCalled();
         });
-      });
 
-      describe("deletedCipher message handler", () => {
+        extensionMessages.forEach((message) => {
-        it("updates the overlay ciphers", () => {
+          it(`triggers an update of the overlay ciphers when the ${message} message is received`, () => {
-          const message = {
+            sendExtensionRuntimeMessage({ command: message });
-            command: "deletedCipher",
+            expect(overlayBackground.updateOverlayCiphers).toHaveBeenCalled();
-          };
+          });
-          jest.spyOn(overlayBackground as any, "updateOverlayCiphers").mockImplementation();
-
-          sendExtensionRuntimeMessage(message);
-
-          expect(overlayBackground["updateOverlayCiphers"]).toHaveBeenCalled();
         });
       });
     });

apps/browser/src/autofill/background/overlay.background.ts

@@ -69,7 +69,9 @@ class OverlayBackground implements OverlayBackgroundInterface {
     updateFocusedFieldData: ({ message }) => this.setFocusedFieldData(message),
     collectPageDetailsResponse: ({ message, sender }) => this.storePageDetails(message, sender),
     unlockCompleted: ({ message }) => this.unlockCompleted(message),
+    addedCipher: () => this.updateOverlayCiphers(),
     addEditCipherSubmitted: () => this.updateOverlayCiphers(),
+    editedCipher: () => this.updateOverlayCiphers(),
     deletedCipher: () => this.updateOverlayCiphers(),
   };
   private readonly overlayButtonPortMessageHandlers: OverlayButtonPortMessageHandlers = {