refactor: [PM-17530] remove obsolete registration component

Remove outdated registration components and associated routes to cleanup the codebase and eliminate legacy functionality.

apps/browser/src/auth/popup/register.component.html

@@ -1,147 +0,0 @@
-<form #form (ngSubmit)="submit()" [appApiAction]="formPromise" [formGroup]="formGroup">
-  <header>
-    <div class="left">
-      <button type="button" routerLink="/home">{{ "cancel" | i18n }}</button>
-    </div>
-    <h1 class="center">
-      <span class="title">{{ "createAccount" | i18n }}</span>
-    </h1>
-    <div class="right">
-      <button type="submit" [disabled]="form.loading">
-        <span [hidden]="form.loading">{{ "submit" | i18n }}</span>
-        <i class="bwi bwi-spinner bwi-lg bwi-spin" [hidden]="!form.loading" aria-hidden="true"></i>
-      </button>
-    </div>
-  </header>
-  <main tabindex="-1">
-    <div class="box">
-      <div class="box-content">
-        <div class="box-content-row" appBoxRow>
-          <label for="email">{{ "emailAddress" | i18n }}</label>
-          <input id="email" type="email" formControlName="email" appInputVerbatim="false" />
-        </div>
-        <div class="box-content-row" appBoxRow>
-          <div class="box-content-row-flex">
-            <div class="row-main">
-              <label for="masterPassword">
-                {{ "masterPass" | i18n }}
-                <strong class="sub-label text-{{ color }}" *ngIf="text">
-                  {{ text }}
-                </strong>
-              </label>
-              <input
-                id="masterPassword"
-                type="{{ showPassword ? 'text' : 'password' }}"
-                aria-describedby="masterPasswordHelp"
-                class="monospaced"
-                formControlName="masterPassword"
-                appInputVerbatim
-              />
-            </div>
-            <div class="action-buttons">
-              <button
-                type="button"
-                class="row-btn"
-                appStopClick
-                appA11yTitle="{{ 'toggleVisibility' | i18n }}"
-                (click)="togglePassword()"
-                [attr.aria-pressed]="showPassword"
-              >
-                <i
-                  class="bwi bwi-lg"
-                  aria-hidden="true"
-                  [ngClass]="{ 'bwi-eye': !showPassword, 'bwi-eye-slash': showPassword }"
-                ></i>
-              </button>
-            </div>
-          </div>
-          <app-password-strength
-            [password]="formGroup.get('masterPassword')?.value"
-            [email]="formGroup.get('email')?.value"
-            [name]="formGroup.get('name')?.value"
-            (passwordStrengthResult)="getStrengthResult($event)"
-            (passwordScoreColor)="getPasswordScoreText($event)"
-          >
-          </app-password-strength>
-        </div>
-      </div>
-      <div id="masterPasswordHelp" class="box-footer">
-        <b>{{ "important" | i18n }}</b> {{ "masterPasswordHint" | i18n }}
-        {{ characterMinimumMessage }}
-      </div>
-    </div>
-    <div class="box">
-      <div class="box-content">
-        <div class="box-content-row box-content-row-flex" appBoxRow>
-          <div class="row-main">
-            <label for="masterPasswordRetype">{{ "reTypeMasterPass" | i18n }}</label>
-            <input
-              id="masterPasswordRetype"
-              type="{{ showPassword ? 'text' : 'password' }}"
-              class="monospaced"
-              formControlName="confirmMasterPassword"
-              appInputVerbatim
-            />
-          </div>
-          <div class="action-buttons">
-            <button
-              type="button"
-              class="row-btn"
-              appStopClick
-              appA11yTitle="{{ 'toggleVisibility' | i18n }}"
-              (click)="togglePassword()"
-              [attr.aria-pressed]="showPassword"
-            >
-              <i
-                class="bwi bwi-lg"
-                aria-hidden="true"
-                [ngClass]="{ 'bwi-eye': !showPassword, 'bwi-eye-slash': showPassword }"
-              ></i>
-            </button>
-          </div>
-        </div>
-        <div class="box-content-row" appBoxRow>
-          <label for="hint">{{ "masterPassHint" | i18n }}</label>
-          <input id="hint" type="text" aria-describedby="hintHelp" formControlName="hint" />
-        </div>
-      </div>
-      <div id="hintHelp" class="box-footer">
-        {{ "masterPassHintDesc" | i18n }}
-      </div>
-      <div class="box-content row-top-padding">
-        <div
-          class="box-content-row box-content-row-checkbox box-content-row-checkbox-left box-content-row-word-break"
-          appBoxRow
-        >
-          <input type="checkbox" id="checkForBreaches" formControlName="checkForBreaches" />
-          <label for="checkForBreaches">
-            {{ "checkForBreaches" | i18n }}
-          </label>
-        </div>
-      </div>
-    </div>
-    <div [hidden]="!showCaptcha()">
-      <iframe id="hcaptcha_iframe" height="80" sandbox="allow-scripts allow-same-origin"></iframe>
-    </div>
-    <div class="box last" *ngIf="showTerms">
-      <div class="box-content">
-        <div
-          class="box-content-row box-content-row-checkbox box-content-row-checkbox-left box-content-row-word-break"
-          appBoxRow
-        >
-          <input type="checkbox" id="acceptPolicies" formControlName="acceptPolicies" />
-          <label for="acceptPolicies">
-            {{ "acceptPolicies" | i18n }}<br />
-            <a href="https://bitwarden.com/terms/" target="_blank" rel="noreferrer">{{
-              "termsOfService" | i18n
-            }}</a
-            >,
-            <a href="https://bitwarden.com/privacy/" target="_blank" rel="noreferrer">{{
-              "privacyPolicy" | i18n
-            }}</a>
-          </label>
-        </div>
-      </div>
-    </div>
-  </main>
-</form>

apps/browser/src/auth/popup/register.component.ts

@@ -1,58 +0,0 @@
-// FIXME: Update this file to be type safe and remove this and next line
-// @ts-strict-ignore
-import { Component } from "@angular/core";
-import { UntypedFormBuilder } from "@angular/forms";
-import { Router } from "@angular/router";
-
-import { RegisterComponent as BaseRegisterComponent } from "@bitwarden/angular/auth/components/register.component";
-import { FormValidationErrorsService } from "@bitwarden/angular/platform/abstractions/form-validation-errors.service";
-import { LoginStrategyServiceAbstraction } from "@bitwarden/auth/common";
-import { ApiService } from "@bitwarden/common/abstractions/api.service";
-import { AuditService } from "@bitwarden/common/abstractions/audit.service";
-import { EnvironmentService } from "@bitwarden/common/platform/abstractions/environment.service";
-import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service";
-import { LogService } from "@bitwarden/common/platform/abstractions/log.service";
-import { PlatformUtilsService } from "@bitwarden/common/platform/abstractions/platform-utils.service";
-import { DialogService, ToastService } from "@bitwarden/components";
-import { KeyService } from "@bitwarden/key-management";
-
-@Component({
-  selector: "app-register",
-  templateUrl: "register.component.html",
-})
-export class RegisterComponent extends BaseRegisterComponent {
-  color: string;
-  text: string;
-
-  constructor(
-    formValidationErrorService: FormValidationErrorsService,
-    formBuilder: UntypedFormBuilder,
-    loginStrategyService: LoginStrategyServiceAbstraction,
-    router: Router,
-    i18nService: I18nService,
-    keyService: KeyService,
-    apiService: ApiService,
-    platformUtilsService: PlatformUtilsService,
-    environmentService: EnvironmentService,
-    logService: LogService,
-    auditService: AuditService,
-    dialogService: DialogService,
-    toastService: ToastService,
-  ) {
-    super(
-      formValidationErrorService,
-      formBuilder,
-      loginStrategyService,
-      router,
-      i18nService,
-      keyService,
-      apiService,
-      platformUtilsService,
-      environmentService,
-      logService,
-      auditService,
-      dialogService,
-      toastService,
-    );
-  }
-}

apps/browser/src/popup/app-routing.module.ts

@@ -64,7 +64,6 @@ import { HomeComponent } from "../auth/popup/home.component";
 import { LoginDecryptionOptionsComponentV1 } from "../auth/popup/login-decryption-options/login-decryption-options-v1.component";
 import { LoginComponentV1 } from "../auth/popup/login-v1.component";
 import { LoginViaAuthRequestComponentV1 } from "../auth/popup/login-via-auth-request-v1.component";
-import { RegisterComponent } from "../auth/popup/register.component";
 import { RemovePasswordComponent } from "../auth/popup/remove-password.component";
 import { SetPasswordComponent } from "../auth/popup/set-password.component";
 import { AccountSecurityComponent } from "../auth/popup/settings/account-security.component";
@@ -267,12 +266,6 @@ const routes: Routes = [
     canActivate: [authGuard],
     data: { elevation: 1 } satisfies RouteDataProperties,
   },
-  {
-    path: "register",
-    component: RegisterComponent,
-    canActivate: [unauthGuardFn(unauthRouteOverrides)],
-    data: { elevation: 1 } satisfies RouteDataProperties,
-  },
   {
     path: "environment",
     component: EnvironmentComponent,

apps/browser/src/popup/app.module.ts

@@ -26,7 +26,6 @@ import { HomeComponent } from "../auth/popup/home.component";
 import { LoginDecryptionOptionsComponentV1 } from "../auth/popup/login-decryption-options/login-decryption-options-v1.component";
 import { LoginComponentV1 } from "../auth/popup/login-v1.component";
 import { LoginViaAuthRequestComponentV1 } from "../auth/popup/login-via-auth-request-v1.component";
-import { RegisterComponent } from "../auth/popup/register.component";
 import { RemovePasswordComponent } from "../auth/popup/remove-password.component";
 import { SetPasswordComponent } from "../auth/popup/set-password.component";
 import { AccountSecurityComponent } from "../auth/popup/settings/account-security.component";
@@ -103,7 +102,6 @@ import "../platform/popup/locales";
     LoginViaAuthRequestComponentV1,
     LoginComponentV1,
     LoginDecryptionOptionsComponentV1,
-    RegisterComponent,
     SetPasswordComponent,
     SsoComponentV1,
     TabsV2Component,

apps/desktop/src/app/app-routing.module.ts

@@ -56,7 +56,6 @@ import { HintComponent } from "../auth/hint.component";
 import { LoginDecryptionOptionsComponentV1 } from "../auth/login/login-decryption-options/login-decryption-options-v1.component";
 import { LoginComponentV1 } from "../auth/login/login-v1.component";
 import { LoginViaAuthRequestComponentV1 } from "../auth/login/login-via-auth-request-v1.component";
-import { RegisterComponent } from "../auth/register.component";
 import { RemovePasswordComponent } from "../auth/remove-password.component";
 import { SetPasswordComponent } from "../auth/set-password.component";
 import { SsoComponentV1 } from "../auth/sso-v1.component";
@@ -136,7 +135,6 @@ const routes: Routes = [
       },
     } satisfies RouteDataProperties & AnonLayoutWrapperData,
   },
-  { path: "register", component: RegisterComponent },
   {
     path: "new-device-notice",
     component: AnonLayoutWrapperComponent,

apps/desktop/src/app/app.module.ts

@@ -15,7 +15,6 @@ import { DeleteAccountComponent } from "../auth/delete-account.component";
 import { EnvironmentComponent } from "../auth/environment.component";
 import { HintComponent } from "../auth/hint.component";
 import { LoginModule } from "../auth/login/login.module";
-import { RegisterComponent } from "../auth/register.component";
 import { RemovePasswordComponent } from "../auth/remove-password.component";
 import { SetPasswordComponent } from "../auth/set-password.component";
 import { SsoComponentV1 } from "../auth/sso-v1.component";
@@ -80,7 +79,6 @@ import { SendComponent } from "./tools/send/send.component";
     NavComponent,
     PasswordHistoryComponent,
     PremiumComponent,
-    RegisterComponent,
     RemovePasswordComponent,
     SearchComponent,
     SendAddEditComponent,

apps/desktop/src/auth/register.component.html

@@ -1,150 +0,0 @@
-<form
-  id="register-page"
-  #form
-  (ngSubmit)="submit()"
-  [appApiAction]="formPromise"
-  [formGroup]="formGroup"
->
-  <div class="content">
-    <h1>{{ "createAccount" | i18n }}</h1>
-    <div class="box">
-      <div class="box-content">
-        <div class="box-content-row" appBoxRow>
-          <label for="email">{{ "emailAddress" | i18n }}</label>
-          <input id="email" type="email" formControlName="email" appInputVerbatim />
-        </div>
-        <div class="box-content-row" appBoxRow>
-          <div class="box-content-row-flex">
-            <div class="row-main">
-              <label for="masterPassword">
-                {{ "masterPass" | i18n }}
-                <strong class="sub-label text-{{ color }}" *ngIf="text">
-                  {{ text }}
-                </strong>
-              </label>
-              <input
-                id="masterPassword"
-                type="{{ showPassword ? 'text' : 'password' }}"
-                class="monospaced"
-                aria-describedby="masterPasswordHelp"
-                formControlName="masterPassword"
-                appInputVerbatim
-              />
-            </div>
-            <div class="action-buttons">
-              <button
-                type="button"
-                class="row-btn"
-                appStopClick
-                appA11yTitle="{{ 'toggleVisibility' | i18n }}"
-                [attr.aria-pressed]="showPassword"
-                (click)="togglePassword()"
-              >
-                <i
-                  class="bwi bwi-lg"
-                  aria-hidden="true"
-                  [ngClass]="{ 'bwi-eye': !showPassword, 'bwi-eye-slash': showPassword }"
-                ></i>
-              </button>
-            </div>
-          </div>
-          <app-password-strength
-            [password]="formGroup.get('masterPassword')?.value"
-            [email]="formGroup.get('email')?.value"
-            [name]="formGroup.get('name')?.value"
-            (passwordStrengthResult)="getStrengthResult($event)"
-            (passwordScoreColor)="getPasswordScoreText($event)"
-          >
-          </app-password-strength>
-        </div>
-      </div>
-      <div id="masterPasswordHelp" class="box-footer">
-        <b>{{ "important" | i18n }}</b> {{ "masterPasswordHint" | i18n }}
-        {{ characterMinimumMessage }}
-      </div>
-    </div>
-    <div class="box">
-      <div class="box-content">
-        <div class="box-content-row box-content-row-flex" appBoxRow>
-          <div class="row-main">
-            <label for="masterPasswordRetype">{{ "reTypeMasterPass" | i18n }}</label>
-            <input
-              id="masterPasswordRetype"
-              type="{{ showPassword ? 'text' : 'password' }}"
-              class="monospaced"
-              formControlName="confirmMasterPassword"
-              appInputVerbatim
-            />
-          </div>
-          <div class="action-buttons">
-            <button
-              type="button"
-              class="row-btn"
-              appStopClick
-              appA11yTitle="{{ 'toggleVisibility' | i18n }}"
-              [attr.aria-pressed]="showPassword"
-              (click)="togglePassword()"
-            >
-              <i
-                class="bwi bwi-lg"
-                aria-hidden="true"
-                [ngClass]="{ 'bwi-eye': !showPassword, 'bwi-eye-slash': showPassword }"
-              ></i>
-            </button>
-          </div>
-        </div>
-        <div class="box-content-row" appBoxRow>
-          <label for="hint">{{ "masterPassHint" | i18n }}</label>
-          <input id="hint" type="text" aria-describedby="hintHelp" formControlName="hint" />
-        </div>
-        <div class="box last" [hidden]="!showCaptcha()">
-          <div class="box-content">
-            <div class="box-content-row">
-              <iframe
-                id="hcaptcha_iframe"
-                height="80"
-                sandbox="allow-scripts allow-same-origin"
-              ></iframe>
-              <button class="btn block" type="button" routerLink="/accessibility-cookie">
-                <i class="bwi bwi-universal-access" aria-hidden="true"></i>
-                {{ "loadAccessibilityCookie" | i18n }}
-              </button>
-            </div>
-          </div>
-        </div>
-      </div>
-      <div id="hintHelp" class="box-footer">
-        {{ "masterPassHintDesc" | i18n }}
-      </div>
-    </div>
-
-    <div class="box last">
-      <div class="box-footer checkbox">
-        <input type="checkbox" id="checkForBreaches" formControlName="checkForBreaches" />
-        <label for="checkForBreaches">
-          {{ "checkForBreaches" | i18n }}
-        </label>
-      </div>
-      <div class="box-footer checkbox" *ngIf="showTerms">
-        <input type="checkbox" id="acceptPolicies" formControlName="acceptPolicies" />
-        <label for="acceptPolicies">
-          {{ "acceptPolicies" | i18n }}<br />
-          <a href="https://bitwarden.com/terms/" target="_blank" rel="noreferrer">{{
-            "termsOfService" | i18n
-          }}</a
-          >,
-          <a href="https://bitwarden.com/privacy/" target="_blank" rel="noreferrer">{{
-            "privacyPolicy" | i18n
-          }}</a>
-        </label>
-      </div>
-    </div>
-    <div class="buttons">
-      <button type="submit" class="btn primary block" [disabled]="form.loading">
-        <b [hidden]="form.loading">{{ "submit" | i18n }}</b>
-        <i class="bwi bwi-spinner bwi-spin" [hidden]="!form.loading" aria-hidden="true"></i>
-      </button>
-      <button type="button" routerLink="/login" class="btn block">{{ "cancel" | i18n }}</button>
-    </div>
-  </div>
-</form>

apps/desktop/src/auth/register.component.ts

@@ -1,83 +0,0 @@
-import { Component, NgZone, OnDestroy, OnInit } from "@angular/core";
-import { UntypedFormBuilder } from "@angular/forms";
-import { Router } from "@angular/router";
-
-import { RegisterComponent as BaseRegisterComponent } from "@bitwarden/angular/auth/components/register.component";
-import { FormValidationErrorsService } from "@bitwarden/angular/platform/abstractions/form-validation-errors.service";
-import { LoginStrategyServiceAbstraction } from "@bitwarden/auth/common";
-import { ApiService } from "@bitwarden/common/abstractions/api.service";
-import { AuditService } from "@bitwarden/common/abstractions/audit.service";
-import { BroadcasterService } from "@bitwarden/common/platform/abstractions/broadcaster.service";
-import { EnvironmentService } from "@bitwarden/common/platform/abstractions/environment.service";
-import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service";
-import { LogService } from "@bitwarden/common/platform/abstractions/log.service";
-import { PlatformUtilsService } from "@bitwarden/common/platform/abstractions/platform-utils.service";
-import { DialogService, ToastService } from "@bitwarden/components";
-import { KeyService } from "@bitwarden/key-management";
-
-const BroadcasterSubscriptionId = "RegisterComponent";
-
-@Component({
-  selector: "app-register",
-  templateUrl: "register.component.html",
-})
-export class RegisterComponent extends BaseRegisterComponent implements OnInit, OnDestroy {
-  constructor(
-    formValidationErrorService: FormValidationErrorsService,
-    formBuilder: UntypedFormBuilder,
-    loginStrategyService: LoginStrategyServiceAbstraction,
-    router: Router,
-    i18nService: I18nService,
-    keyService: KeyService,
-    apiService: ApiService,
-    platformUtilsService: PlatformUtilsService,
-    environmentService: EnvironmentService,
-    private broadcasterService: BroadcasterService,
-    private ngZone: NgZone,
-    logService: LogService,
-    auditService: AuditService,
-    dialogService: DialogService,
-    toastService: ToastService,
-  ) {
-    super(
-      formValidationErrorService,
-      formBuilder,
-      loginStrategyService,
-      router,
-      i18nService,
-      keyService,
-      apiService,
-      platformUtilsService,
-      environmentService,
-      logService,
-      auditService,
-      dialogService,
-      toastService,
-    );
-  }
-
-  async ngOnInit() {
-    this.broadcasterService.subscribe(BroadcasterSubscriptionId, async (message: any) => {
-      this.ngZone.run(() => {
-        switch (message.command) {
-          case "windowHidden":
-            this.onWindowHidden();
-            break;
-          default:
-        }
-      });
-    });
-
-    // FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
-    // eslint-disable-next-line @typescript-eslint/no-floating-promises
-    super.ngOnInit();
-  }
-
-  ngOnDestroy() {
-    this.broadcasterService.unsubscribe(BroadcasterSubscriptionId);
-  }
-
-  onWindowHidden() {
-    this.showPassword = false;
-  }
-}