bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2026-01-06 02:23:44 +00:00
Code Issues Releases Wiki Activity

add/improve comments and logging

Browse Source
This commit is contained in:
John Harrington
2025-11-20 09:51:49 -07:00
parent 61b26241ad
commit 18064efc4f
10 changed files with 35 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/desktop/src/app/tools/import/chromium-importer.service.ts
View File

@@ -9,6 +9,7 @@ export class ChromiumImporterService {
return await chromium_importer.getMetadata();
});
// Used on Mac OS App Store builds to request permissions to browser entries outside the sandbox
ipcMain.handle("chromium_importer.requestBrowserAccess", async (event, browser: string) => {
console.log("[IPC] requestBrowserAccess handler called for:", browser);
console.log("[IPC] chromium_importer keys:", Object.keys(chromium_importer));
@@ -21,7 +22,6 @@ export class ChromiumImporterService {
console.log("[IPC] Calling native requestBrowserAccess");
return await chromium_importer.requestBrowserAccess(browser);
}
// No-op if not compiled with sandbox support
console.log("[IPC] requestBrowserAccess not found, returning no-op");
return;
});

1
apps/desktop/src/app/tools/import/import-desktop.component.ts
View File

@@ -40,7 +40,6 @@ export class ImportDesktopComponent {
protected disabled = false;
protected loading = false;
// Bind callbacks in constructor to maintain reference equality
protected readonly onLoadProfilesFromBrowser = this._onLoadProfilesFromBrowser.bind(this);
protected readonly onImportFromBrowser = this._onImportFromBrowser.bind(this);

2
apps/desktop/src/app/tools/preload.ts
View File

@@ -5,7 +5,7 @@ import type { chromium_importer } from "@bitwarden/desktop-napi";
const chromiumImporter = {
getMetadata: (): Promise<Record<string, chromium_importer.NativeImporterMetadata>> =>
ipcRenderer.invoke("chromium_importer.getMetadata"),
// Request browser access for sandboxed builds (no-op in non-sandboxed builds)
// Request browser access for Mac OS App Store (sandboxed) builds (no-op in non-sandboxed builds)
requestBrowserAccess: (browser: string): Promise<void> =>
ipcRenderer.invoke("chromium_importer.requestBrowserAccess", browser),
getAvailableProfiles: (browser: string): Promise<chromium_importer.ProfileInfo[]> =>