bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-20 18:23:31 +00:00
Code Issues Releases Wiki Activity

Linter updates and fixes (#1604)

Browse Source
This commit is contained in:
Matt Gibson
2021-02-10 09:40:15 -06:00
committed by GitHub
parent dae739bc17
commit 1868b99d17
17 changed files with 73 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/services/autofill.service.ts
View File

@@ -41,14 +41,14 @@ const FirstnameFieldNames: string[] = [
// English
'f-name', 'first-name', 'given-name', 'first-n',
// German
'vorname'
'vorname',
];
const LastnameFieldNames: string[] = [
// English
'l-name', 'last-name', 's-name', 'surname', 'family-name', 'family-n', 'last-n',
// German
'nachname', 'familienname'
'nachname', 'familienname',
];
const ExcludedAutofillTypes: string[] = ['radio', 'checkbox', 'hidden', 'file', 'button', 'image', 'reset', 'search'];
@@ -150,7 +150,7 @@ export default class AutofillService implements AutofillServiceInterface {
continue;
}
const formPasswordFields = passwordFields.filter((pf) => formKey === pf.form);
const formPasswordFields = passwordFields.filter(pf => formKey === pf.form);
if (formPasswordFields.length > 0) {
let uf = this.findUsernameField(pageDetails, formPasswordFields[0], false, false, false);
if (uf == null) {
@@ -215,7 +215,7 @@ export default class AutofillService implements AutofillServiceInterface {
return;
}
totpPromise = this.totpService.isAutoCopyEnabled().then((enabled) => {
totpPromise = this.totpService.isAutoCopyEnabled().then(enabled => {
if (enabled) {
return this.totpService.getCode(options.cipher.login.totp);
}
@@ -369,13 +369,13 @@ export default class AutofillService implements AutofillServiceInterface {
}
const passwordFieldsForForm: AutofillField[] = [];
passwordFields.forEach((passField) => {
passwordFields.forEach(passField => {
if (formKey === passField.form) {
passwordFieldsForForm.push(passField);
}
});
passwordFields.forEach((passField) => {
passwordFields.forEach(passField => {
pf = passField;
passwords.push(pf);
@@ -425,7 +425,7 @@ export default class AutofillService implements AutofillServiceInterface {
});
}
usernames.forEach((u) => {
usernames.forEach(u => {
if (filledFields.hasOwnProperty(u.opid)) {
return;
}
@@ -434,7 +434,7 @@ export default class AutofillService implements AutofillServiceInterface {
this.fillByOpid(fillScript, u, login.username);
});
passwords.forEach((p) => {
passwords.forEach(p => {
if (filledFields.hasOwnProperty(p.opid)) {
return;
}
@@ -666,7 +666,7 @@ export default class AutofillService implements AutofillServiceInterface {
}
let doesContain = false;
CardAttributesExtended.forEach((attr) => {
CardAttributesExtended.forEach(attr => {
if (doesContain || !field.hasOwnProperty(attr) || !field[attr]) {
return;
}
@@ -924,7 +924,7 @@ export default class AutofillService implements AutofillServiceInterface {
private loadPasswordFields(pageDetails: AutofillPageDetails, canBeHidden: boolean, canBeReadOnly: boolean,
mustBeEmpty: boolean, fillNewPassword: boolean) {
const arr: AutofillField[] = [];
pageDetails.fields.forEach((f) => {
pageDetails.fields.forEach(f => {
const isPassword = f.type === 'password';
const valueIsLikePassword = (value: string) => {
if (value == null) {
@@ -938,7 +938,7 @@ export default class AutofillService implements AutofillServiceInterface {
}
const ignoreList = ['onetimepassword', 'captcha', 'findanything'];
if (ignoreList.some((i) => cleanedValue.indexOf(i) > -1)) {
if (ignoreList.some(i => cleanedValue.indexOf(i) > -1)) {
return false;
}

6
src/services/browserPlatformUtils.service.ts
View File

@@ -158,7 +158,7 @@ export default class BrowserPlatformUtilsService implements PlatformUtilsService
type: type,
dialogId: dialogId,
});
return new Promise<boolean>((resolve) => {
return new Promise<boolean>(resolve => {
this.showDialogResolves.set(dialogId, { resolve: resolve, date: new Date() });
});
}
@@ -190,7 +190,7 @@ export default class BrowserPlatformUtilsService implements PlatformUtilsService
}
const clearing = options ? !!options.clearing : false;
const clearMs: number = options && options.clearMs ? options.clearMs : null;
if (this.isSafari()) {
SafariApp.sendMessageToApp('copyToClipboard', text).then(() => {
if (!clearing && this.clipboardWriteCallback != null) {
@@ -285,7 +285,7 @@ export default class BrowserPlatformUtilsService implements PlatformUtilsService
deleteIds.push(key);
}
});
deleteIds.forEach((id) => {
deleteIds.forEach(id => {
this.showDialogResolves.delete(id);
});
}

8
src/services/browserStorage.service.ts
View File

@@ -8,7 +8,7 @@ export default class BrowserStorageService implements StorageService {
}
async get<T>(key: string): Promise<T> {
return new Promise((resolve) => {
return new Promise(resolve => {
this.chromeStorageApi.get(key, (obj: any) => {
if (obj != null && obj[key] != null) {
resolve(obj[key] as T);
@@ -22,7 +22,7 @@ export default class BrowserStorageService implements StorageService {
async save(key: string, obj: any): Promise<any> {
if (obj == null) {
// Fix safari not liking null in set
return new Promise((resolve) => {
return new Promise(resolve => {
this.chromeStorageApi.remove(key, () => {
resolve();
});
@@ -30,7 +30,7 @@ export default class BrowserStorageService implements StorageService {
}
const keyedObj = { [key]: obj };
return new Promise((resolve) => {
return new Promise(resolve => {
this.chromeStorageApi.set(keyedObj, () => {
resolve();
});
@@ -38,7 +38,7 @@ export default class BrowserStorageService implements StorageService {
}
async remove(key: string): Promise<any> {
return new Promise((resolve) => {
return new Promise(resolve => {
this.chromeStorageApi.remove(key, () => {
resolve();
});