bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-14 07:13:32 +00:00
Code Issues Releases Wiki Activity

SG-680 - OrgDomain.service - replace delete with splice as delete doesn't actually alter array. Duh.

Browse Source
This commit is contained in:
Jared Snider
2022-12-08 17:50:47 -05:00
parent e57faf2e63
commit 19e7513d65
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libs/common/src/services/organization-domain/org-domain.service.ts
View File

@@ -54,7 +54,7 @@ export class OrgDomainService implements OrgDomainInternalServiceAbstraction {
); );
if (index !== -1) { if (index !== -1) {
// existing // existing
delete existingOrgDomains[index]; existingOrgDomains.splice(index, 1);
} else { } else {
// eslint-disable-next-line no-console // eslint-disable-next-line no-console
console.warn(`Unable to delete OrgDomainId: ${orgDomainId}`); console.warn(`Unable to delete OrgDomainId: ${orgDomainId}`);