bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-18 09:13:33 +00:00
Code Issues Releases Wiki Activity

[EC-598] feat: add abort controller all the way to service

Browse Source
This commit is contained in:
Andreas Coroiu
2023-01-27 17:02:11 +01:00
parent f6eae754b3
commit 1ad0bc547a
6 changed files with 42 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
libs/common/src/abstractions/fido2/fido2.service.abstraction.ts
View File

@@ -85,6 +85,12 @@ export class OriginMismatchError extends Fido2Error {
}
export abstract class Fido2Service {
createCredential: (params: CredentialRegistrationParams) => Promise<CredentialRegistrationResult>;
assertCredential: (params: CredentialAssertParams) => Promise<CredentialAssertResult>;
createCredential: (
params: CredentialRegistrationParams,
abortController?: AbortController
) => Promise<CredentialRegistrationResult>;
assertCredential: (
params: CredentialAssertParams,
abortController?: AbortController
) => Promise<CredentialAssertResult>;
}

3
libs/common/src/services/fido2/fido2.service.ts
View File

@@ -45,7 +45,8 @@ export class Fido2Service implements Fido2ServiceAbstraction {
) {}
async createCredential(
params: CredentialRegistrationParams
params: CredentialRegistrationParams,
abortController?: AbortController
): Promise<CredentialRegistrationResult> {
const presence = await this.fido2UserInterfaceService.confirmNewCredential({
credentialName: params.rp.name,