From 1b3a2ecf49a99df41544f44529fe5b91dc283e54 Mon Sep 17 00:00:00 2001 From: Todd Martin Date: Tue, 18 Mar 2025 16:12:35 -0400 Subject: [PATCH] Fixed tests --- .../sso-login.strategy.spec.ts | 22 ++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/libs/auth/src/common/login-strategies/sso-login.strategy.spec.ts b/libs/auth/src/common/login-strategies/sso-login.strategy.spec.ts index 546fa0c5fa7..37b4d7dc323 100644 --- a/libs/auth/src/common/login-strategies/sso-login.strategy.spec.ts +++ b/libs/auth/src/common/login-strategies/sso-login.strategy.spec.ts @@ -34,6 +34,7 @@ import { DeviceKey, UserKey, MasterKey } from "@bitwarden/common/types/key"; import { KdfConfigService, KeyService } from "@bitwarden/key-management"; import { + AuthRequestApiService, AuthRequestServiceAbstraction, InternalUserDecryptionOptionsServiceAbstraction, } from "../abstractions"; @@ -65,6 +66,7 @@ describe("SsoLoginStrategy", () => { let vaultTimeoutSettingsService: MockProxy; let kdfConfigService: MockProxy; let environmentService: MockProxy; + let authRequestApiService: MockProxy; let ssoLoginStrategy: SsoLoginStrategy; let credentials: SsoLoginCredentials; @@ -101,6 +103,7 @@ describe("SsoLoginStrategy", () => { vaultTimeoutSettingsService = mock(); kdfConfigService = mock(); environmentService = mock(); + authRequestApiService = mock(); tokenService.getTwoFactorToken.mockResolvedValue(null); appIdService.getAppId.mockResolvedValue(deviceId); @@ -129,6 +132,7 @@ describe("SsoLoginStrategy", () => { deviceTrustService, authRequestService, i18nService, + authRequestApiService, accountService, masterPasswordService, keyService, @@ -375,7 +379,9 @@ describe("SsoLoginStrategy", () => { masterPasswordHash: "HASH" as any, requestApproved: true, }; - apiService.getAuthRequest.mockResolvedValue(adminAuthResponse as AuthRequestResponse); + authRequestApiService.getAuthRequest.mockResolvedValue( + adminAuthResponse as AuthRequestResponse, + ); await ssoLoginStrategy.logIn(credentials); @@ -392,7 +398,9 @@ describe("SsoLoginStrategy", () => { key: "KEY" as any, requestApproved: true, }; - apiService.getAuthRequest.mockResolvedValue(adminAuthResponse as AuthRequestResponse); + authRequestApiService.getAuthRequest.mockResolvedValue( + adminAuthResponse as AuthRequestResponse, + ); await ssoLoginStrategy.logIn(credentials); @@ -409,7 +417,9 @@ describe("SsoLoginStrategy", () => { key: "KEY" as any, requestApproved: true, }; - apiService.getAuthRequest.mockResolvedValue(adminAuthResponse as AuthRequestResponse); + authRequestApiService.getAuthRequest.mockResolvedValue( + adminAuthResponse as AuthRequestResponse, + ); await ssoLoginStrategy.logIn(credentials); @@ -419,7 +429,7 @@ describe("SsoLoginStrategy", () => { it("clears the admin auth request if server returns a 404, meaning it was deleted", async () => { apiService.postIdentityToken.mockResolvedValue(tokenResponse); - apiService.getAuthRequest.mockRejectedValue(new ErrorResponse(null, 404)); + authRequestApiService.getAuthRequest.mockRejectedValue(new ErrorResponse(null, 404)); await ssoLoginStrategy.logIn(credentials); @@ -439,7 +449,9 @@ describe("SsoLoginStrategy", () => { key: "KEY" as any, requestApproved: true, }; - apiService.getAuthRequest.mockResolvedValue(adminAuthResponse as AuthRequestResponse); + authRequestApiService.getAuthRequest.mockResolvedValue( + adminAuthResponse as AuthRequestResponse, + ); keyService.hasUserKey.mockResolvedValue(false); deviceTrustService.getDeviceKey.mockResolvedValue("DEVICE_KEY" as any);