mirror of
https://github.com/bitwarden/browser
synced 2025-12-11 22:03:36 +00:00
PM-14445: Auth SSO Login TS strict failures (#13335)
This commit is contained in:
@@ -367,7 +367,7 @@ export class SsoComponent implements OnInit {
|
||||
codeVerifier,
|
||||
redirectUri,
|
||||
orgSsoIdentifier,
|
||||
email,
|
||||
email ?? undefined,
|
||||
);
|
||||
this.formPromise = this.loginStrategyService.logIn(credentials);
|
||||
const authResult = await this.formPromise;
|
||||
|
||||
@@ -11,7 +11,7 @@ export abstract class SsoLoginServiceAbstraction {
|
||||
* @see https://datatracker.ietf.org/doc/html/rfc7636
|
||||
* @returns The code verifier used for SSO.
|
||||
*/
|
||||
abstract getCodeVerifier: () => Promise<string>;
|
||||
abstract getCodeVerifier: () => Promise<string | null>;
|
||||
/**
|
||||
* Sets the code verifier used for SSO.
|
||||
*
|
||||
@@ -31,7 +31,7 @@ export abstract class SsoLoginServiceAbstraction {
|
||||
* @see https://datatracker.ietf.org/doc/html/rfc6749#section-4.1
|
||||
* @returns The SSO state.
|
||||
*/
|
||||
abstract getSsoState: () => Promise<string>;
|
||||
abstract getSsoState: () => Promise<string | null>;
|
||||
/**
|
||||
* Sets the value of the SSO state.
|
||||
*
|
||||
@@ -48,7 +48,7 @@ export abstract class SsoLoginServiceAbstraction {
|
||||
* Do not use this value outside of the SSO login flow.
|
||||
* @returns The user's organization identifier.
|
||||
*/
|
||||
abstract getOrganizationSsoIdentifier: () => Promise<string>;
|
||||
abstract getOrganizationSsoIdentifier: () => Promise<string | null>;
|
||||
/**
|
||||
* Sets the value of the user's organization sso identifier.
|
||||
*
|
||||
@@ -61,7 +61,7 @@ export abstract class SsoLoginServiceAbstraction {
|
||||
* Note: This should only be used during the SSO flow to identify the user that is attempting to log in.
|
||||
* @returns The user's email.
|
||||
*/
|
||||
abstract getSsoEmail: () => Promise<string>;
|
||||
abstract getSsoEmail: () => Promise<string | null>;
|
||||
/**
|
||||
* Sets the user's email.
|
||||
* Note: This should only be used during the SSO flow to identify the user that is attempting to log in.
|
||||
|
||||
@@ -73,7 +73,7 @@ export class SsoLoginService implements SsoLoginServiceAbstraction {
|
||||
this.ssoEmailState = this.stateProvider.getGlobal(SSO_EMAIL);
|
||||
}
|
||||
|
||||
getCodeVerifier(): Promise<string> {
|
||||
getCodeVerifier(): Promise<string | null> {
|
||||
return firstValueFrom(this.codeVerifierState.state$);
|
||||
}
|
||||
|
||||
@@ -81,7 +81,7 @@ export class SsoLoginService implements SsoLoginServiceAbstraction {
|
||||
await this.codeVerifierState.update((_) => codeVerifier);
|
||||
}
|
||||
|
||||
getSsoState(): Promise<string> {
|
||||
getSsoState(): Promise<string | null> {
|
||||
return firstValueFrom(this.ssoState.state$);
|
||||
}
|
||||
|
||||
@@ -89,7 +89,7 @@ export class SsoLoginService implements SsoLoginServiceAbstraction {
|
||||
await this.ssoState.update((_) => ssoState);
|
||||
}
|
||||
|
||||
getOrganizationSsoIdentifier(): Promise<string> {
|
||||
getOrganizationSsoIdentifier(): Promise<string | null> {
|
||||
return firstValueFrom(this.orgSsoIdentifierState.state$);
|
||||
}
|
||||
|
||||
@@ -97,7 +97,7 @@ export class SsoLoginService implements SsoLoginServiceAbstraction {
|
||||
await this.orgSsoIdentifierState.update((_) => organizationIdentifier);
|
||||
}
|
||||
|
||||
getSsoEmail(): Promise<string> {
|
||||
getSsoEmail(): Promise<string | null> {
|
||||
return firstValueFrom(this.ssoEmailState.state$);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user