bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-18 01:03:35 +00:00
Code Issues Releases Wiki Activity

[EC-598] feat: confirm new credentials

Browse Source
This commit is contained in:
Andreas Coroiu
2022-12-16 10:13:52 +01:00
parent 1d8dfaaf8d
commit 1ca9d73f10
9 changed files with 79 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
libs/common/src/abstractions/fido2/fido2-user-interface.service.abstraction.ts
View File

@@ -1,4 +1,5 @@
export abstract class Fido2UserInterfaceService {
verifyUser: () => Promise<boolean>;
verifyPresence: () => Promise<boolean>;
confirmNewCredential: () => Promise<boolean>;
}

2
libs/common/src/services/fido2/fido2.service.ts
View File

@@ -8,7 +8,7 @@ export class Fido2Service implements Fido2ServiceAbstraction {
constructor(private fido2UserInterfaceService: Fido2UserInterfaceService) {}
async createCredential(params: CredentialRegistrationParams): Promise<unknown> {
await this.fido2UserInterfaceService.verifyPresence();
await this.fido2UserInterfaceService.confirmNewCredential();
// eslint-disable-next-line no-console
console.log("Fido2Service.registerCredential", params);
return "createCredential response";

4
libs/common/src/services/fido2/noop-fido2-user-interface.service.ts
View File

@@ -8,4 +8,8 @@ export class Fido2UserInterfaceService implements Fido2UserInterfaceServiceAbstr
async verifyPresence(): Promise<boolean> {
return false;
}
async confirmNewCredential(): Promise<boolean> {
return false;
}
}