[PM-20999] Styling corrections to Access Intelligence - Part 2 (#14552)

apps/web/src/locales/en/messages.json

@@ -140,9 +140,15 @@
   "atRiskMembersDescription": {
     "message": "These members are logging into applications with weak, exposed, or reused passwords."
   },
+  "atRiskMembersDescriptionNone": {
+    "message": "These are no members logging into applications with weak, exposed, or reused passwords."
+  },
   "atRiskApplicationsDescription": {
     "message": "These applications have weak, exposed, or reused passwords."
   },
+  "atRiskApplicationsDescriptionNone": {
+    "message": "These are no applications with weak, exposed, or reused passwords."
+  },
   "atRiskMembersDescriptionWithApp": {
     "message": "These members are logging into $APPNAME$ with weak, exposed, or reused passwords.",
     "placeholders": {
@@ -152,6 +158,15 @@
       }
     }
   },
+  "atRiskMembersDescriptionWithAppNone": {
+    "message": "There are no at risk members for $APPNAME$.",
+    "placeholders": {
+      "appname": {
+        "content": "$1",
+        "example": "Salesforce"
+      }
+    }
+  },
   "totalMembers": {
     "message": "Total members"
   },

bitwarden_license/bit-web/src/app/dirt/access-intelligence/app-table-row-scrollable.component.html

@@ -89,7 +89,7 @@
 
         <bit-menu #rowMenu>
           <button type="button" bitMenuItem (click)="unmarkAsCriticalApp(row.applicationName)">
-            <i aria-hidden="true" class="bwi bwi-star-f"></i> {{ "unmarkAsCriticalApp" | i18n }}
+            {{ "unmarkAsCriticalApp" | i18n }}
           </button>
         </bit-menu>
       </td>

bitwarden_license/bit-web/src/app/dirt/access-intelligence/risk-insights.component.html

@@ -68,8 +68,12 @@
         </bit-drawer-header>
         <bit-drawer-body>
           <span bitTypography="body1" class="tw-text-muted tw-text-sm">{{
-            "atRiskMembersDescription" | i18n
+            (dataService.atRiskMemberDetails.length > 0
+              ? "atRiskMembersDescription"
+              : "atRiskMembersDescriptionNone"
+            ) | i18n
           }}</span>
+          <ng-container *ngIf="dataService.atRiskMemberDetails.length > 0">
             <div class="tw-flex tw-justify-between tw-mt-2 tw-text-muted">
               <div bitTypography="body2" class="tw-text-sm tw-font-bold">{{ "email" | i18n }}</div>
               <div bitTypography="body2" class="tw-text-sm tw-font-bold">
@@ -82,6 +86,7 @@
                 <div>{{ member.atRiskPasswordCount }}</div>
               </div>
             </ng-container>
+          </ng-container>
         </bit-drawer-body>
       </ng-container>
 
@@ -94,7 +99,10 @@
           </div>
           <div bitTypography="body1" class="tw-text-muted tw-text-sm tw-mb-2">
             {{
-              "atRiskMembersDescriptionWithApp" | i18n: dataService.appAtRiskMembers.applicationName
+              (dataService.appAtRiskMembers.members.length > 0
+                ? "atRiskMembersDescriptionWithApp"
+                : "atRiskMembersDescriptionWithAppNone"
+              ) | i18n: dataService.appAtRiskMembers.applicationName
             }}
           </div>
           <div class="tw-mt-1">
@@ -113,8 +121,12 @@
 
         <bit-drawer-body>
           <span bitTypography="body2" class="tw-text-muted tw-text-sm">{{
-            "atRiskApplicationsDescription" | i18n
+            (dataService.atRiskAppDetails.length > 0
+              ? "atRiskApplicationsDescription"
+              : "atRiskApplicationsDescriptionNone"
+            ) | i18n
           }}</span>
+          <ng-container *ngIf="dataService.atRiskAppDetails.length > 0">
             <div class="tw-flex tw-justify-between tw-mt-2 tw-text-muted">
               <div bitTypography="body2" class="tw-text-sm tw-font-bold">
                 {{ "application" | i18n }}
@@ -129,6 +141,7 @@
                 <div>{{ app.atRiskPasswordCount }}</div>
               </div>
             </ng-container>
+          </ng-container>
         </bit-drawer-body>
       </ng-container>
     </bit-drawer>