bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-17 08:43:33 +00:00
Code Issues Releases Wiki Activity

Revert "skip vis checks for notification bar collect()"

Browse Source 
This reverts commit 9f51f005b0.
This commit is contained in:
Kyle Spearrin
2017-10-02 10:29:46 -04:00
parent 9f51f005b0
commit 1e18827b61
5 changed files with 13 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/background.js
View File

@@ -67,7 +67,7 @@ var bg_isBackground = true,
hitType: 'event',
eventAction: 'Autofilled From Command'
});
collectPageDetailsForContentScript(tabs[0], 'autofill_cmd', false);
collectPageDetailsForContentScript(tabs[0], 'autofill_cmd');
}
});
}
@@ -101,7 +101,7 @@ var bg_isBackground = true,
messageTab(sender.tab.id, 'adjustNotificationBar', msg.data);
}
else if (msg.command === 'bgCollectPageDetails') {
collectPageDetailsForContentScript(sender.tab, msg.sender, msg.noVisibleChecks);
collectPageDetailsForContentScript(sender.tab, msg.sender);
}
else if (msg.command === 'bgAddLogin') {
addLogin(msg.login, sender.tab);
@@ -560,17 +560,12 @@ var bg_isBackground = true,
});
}
function collectPageDetailsForContentScript(tab, sender, noVisibleChecks) {
function collectPageDetailsForContentScript(tab, sender) {
if (!tab || !tab.id) {
return;
}
chrome.tabs.sendMessage(tab.id, {
command: 'collectPageDetails',
tab: tab,
sender: sender,
noVisibleChecks: noVisibleChecks
}, function () {
chrome.tabs.sendMessage(tab.id, { command: 'collectPageDetails', tab: tab, sender: sender }, function () {
if (chrome.runtime.lastError) {
return;
}
@@ -742,12 +737,7 @@ var bg_isBackground = true,
return;
}
chrome.tabs.sendMessage(tab.id, {
command: 'collectPageDetails',
tab: tab,
sender: 'contextMenu',
noVisibleChecks: false
}, function () {
chrome.tabs.sendMessage(tab.id, { command: 'collectPageDetails', tab: tab, sender: 'contextMenu' }, function () {
});
});
}