Add support to import from Nordpass(.csv) (#360)

* Add support for parsing .csv files from Nordpass

* Remove whitespace before extracting CardExpiration

* Add curlybraces to one-liner if's as requested

* NordPassImporter: Process more complex names

spec/common/importers/nordpassCsvImporter.spec.ts

@@ -0,0 +1,179 @@
+import { NordPassCsvImporter as Importer } from '../../../src/importers/nordpassCsvImporter';
+
+import { CipherType, SecureNoteType } from '../../../src/enums';
+import { CipherView, IdentityView } from '../../../src/models/view/';
+
+import { data as creditCardData } from './testData/nordpassCsv/nordpass.card.csv';
+import { data as identityData } from './testData/nordpassCsv/nordpass.identity.csv';
+import { data as loginData } from './testData/nordpassCsv/nordpass.login.csv';
+import { data as secureNoteData } from './testData/nordpassCsv/nordpass.secureNote.csv';
+
+const namesTestData = [
+    {
+        title: 'Given #fullName should set firstName',
+        fullName: 'MyFirstName',
+        expected: Object.assign(new IdentityView(), {
+            firstName: 'MyFirstName',
+            middleName: null,
+            lastName: null,
+        }),
+    },
+    {
+        title: 'Given #fullName should set first- and lastName',
+        fullName: 'MyFirstName MyLastName',
+        expected: Object.assign(new IdentityView(), {
+            firstName: 'MyFirstName',
+            middleName: null,
+            lastName: 'MyLastName',
+        }),
+    },
+    {
+        title: 'Given #fullName should set first-, middle and lastName',
+        fullName: 'MyFirstName MyMiddleName MyLastName',
+        expected: Object.assign(new IdentityView(), {
+            firstName: 'MyFirstName',
+            middleName: 'MyMiddleName',
+            lastName: 'MyLastName',
+        }),
+    },
+    {
+        title: 'Given #fullName should set first-, middle and lastName with Jr',
+        fullName: 'MyFirstName MyMiddleName MyLastName Jr',
+        expected: Object.assign(new IdentityView(), {
+            firstName: 'MyFirstName',
+            middleName: 'MyMiddleName',
+            lastName: 'MyLastName Jr',
+        }),
+    },
+    {
+        title: 'Given #fullName should set first-, middle and lastName with Jr and III',
+        fullName: 'MyFirstName MyMiddleName MyLastName Jr III',
+        expected: Object.assign(new IdentityView(), {
+            firstName: 'MyFirstName',
+            middleName: 'MyMiddleName',
+            lastName: 'MyLastName Jr III',
+        }),
+    },
+];
+
+
+function expectLogin(cipher: CipherView) {
+    expect(cipher.type).toBe(CipherType.Login);
+
+    expect(cipher.name).toBe('SomeVaultItemName');
+    expect(cipher.notes).toBe('Some note for the VaultItem');
+    expect(cipher.login.uri).toBe('https://example.com');
+    expect(cipher.login.username).toBe('hello@bitwarden.com');
+    expect(cipher.login.password).toBe('someStrongPassword');
+}
+
+function expectCreditCard(cipher: CipherView) {
+    expect(cipher.type).toBe(CipherType.Card);
+
+    expect(cipher.name).toBe('SomeVisa');
+    expect(cipher.card.brand).toBe('Visa');
+    expect(cipher.card.cardholderName).toBe('SomeHolder');
+    expect(cipher.card.number).toBe('4024007103939509');
+    expect(cipher.card.code).toBe('123');
+    expect(cipher.card.expMonth).toBe('1');
+    expect(cipher.card.expYear).toBe('22');
+}
+
+function expectIdentity(cipher: CipherView) {
+    expect(cipher.type).toBe(CipherType.Identity);
+
+    expect(cipher.name).toBe('SomeTitle');
+    expect(cipher.identity.fullName).toBe('MyFirstName MyMiddleName MyLastName');
+    expect(cipher.identity.firstName).toBe('MyFirstName');
+    expect(cipher.identity.middleName).toBe('MyMiddleName');
+    expect(cipher.identity.lastName).toBe('MyLastName');
+    expect(cipher.identity.email).toBe('hello@bitwarden.com');
+    expect(cipher.identity.phone).toBe('123456789');
+
+    expect(cipher.identity.address1).toBe('Test street 123');
+    expect(cipher.identity.address2).toBe('additional addressinfo');
+    expect(cipher.identity.postalCode).toBe('123456');
+    expect(cipher.identity.city).toBe('Cologne');
+    expect(cipher.identity.state).toBe('North-Rhine-Westphalia');
+    expect(cipher.identity.country).toBe('GERMANY');
+    expect(cipher.notes).toBe('SomeNoteToMyIdentity');
+}
+
+function expectSecureNote(cipher: CipherView) {
+    expect(cipher.type).toBe(CipherType.SecureNote);
+
+    expect(cipher.name).toBe('MySuperSecureNoteTitle');
+    expect(cipher.secureNote.type).toBe(SecureNoteType.Generic);
+    expect(cipher.notes).toBe('MySuperSecureNote');
+}
+
+describe('NordPass CSV Importer', () => {
+    let importer: Importer;
+    beforeEach(() => {
+        importer = new Importer();
+    });
+
+    it('should parse login records', async () => {
+        const result = await importer.parse(loginData);
+
+        expect(result).not.toBeNull();
+        expect(result.success).toBe(true);
+        expect(result.ciphers.length).toBe(1);
+        const cipher = result.ciphers[0];
+        expectLogin(cipher);
+    });
+
+    it('should parse credit card records', async () => {
+        const result = await importer.parse(creditCardData);
+
+        expect(result).not.toBeNull();
+        expect(result.success).toBe(true);
+        expect(result.ciphers.length).toBe(1);
+        const cipher = result.ciphers[0];
+        expectCreditCard(cipher);
+    });
+
+    it('should parse identity records', async () => {
+        const result = await importer.parse(identityData.replace('#fullName', 'MyFirstName MyMiddleName MyLastName'));
+
+        expect(result).not.toBeNull();
+        expect(result.success).toBe(true);
+        expect(result.ciphers.length).toBe(1);
+        const cipher = result.ciphers[0];
+        expectIdentity(cipher);
+    });
+
+    namesTestData.forEach(data => {
+        it(data.title.replace('#fullName', data.fullName), async () => {
+            const result = await importer.parse(identityData.replace('#fullName', data.fullName));
+
+            expect(result).not.toBeNull();
+            expect(result.success).toBe(true);
+            expect(result.ciphers.length).toBe(1);
+            const cipher = result.ciphers[0];
+            expect(cipher.identity.firstName).toBe(data.expected.firstName);
+            expect(cipher.identity.middleName).toBe(data.expected.middleName);
+            expect(cipher.identity.lastName).toBe(data.expected.lastName);
+        });
+    });
+
+    it('should parse secureNote records', async () => {
+        const result = await importer.parse(secureNoteData);
+
+        expect(result).not.toBeNull();
+        expect(result.success).toBe(true);
+        expect(result.ciphers.length).toBe(1);
+        const cipher = result.ciphers[0];
+        expectSecureNote(cipher);
+    });
+
+    it('should parse an item and create a folder', async () => {
+        const result = await importer.parse(secureNoteData);
+
+        expect(result).not.toBeNull();
+        expect(result.success).toBe(true);
+        expect(result.folders.length).toBe(1);
+        const folder = result.folders[0];
+        expect(folder.name).toBe('notesFolder');
+    });
+});

spec/common/importers/testData/nordpassCsv/nordpass.card.csv.ts

@@ -0,0 +1,2 @@
+export const data = `name,url,username,password,note,cardholdername,cardnumber,cvc,expirydate,zipcode,folder,full_name,phone_number,email,address1,address2,city,country,state
+SomeVisa,,,,,SomeHolder,4024007103939509,123,01 / 22,12345,,,,,,,,,`;

spec/common/importers/testData/nordpassCsv/nordpass.identity.csv.ts

@@ -0,0 +1,2 @@
+export const data = `name,url,username,password,note,cardholdername,cardnumber,cvc,expirydate,zipcode,folder,full_name,phone_number,email,address1,address2,city,country,state
+SomeTitle,,,,SomeNoteToMyIdentity,,,,,123456,,#fullName,123456789,hello@bitwarden.com,Test street 123,additional addressinfo,Cologne,Germany,North-Rhine-Westphalia`;

spec/common/importers/testData/nordpassCsv/nordpass.login.csv.ts

@@ -0,0 +1,2 @@
+export const data = `name,url,username,password,note,cardholdername,cardnumber,cvc,expirydate,zipcode,folder,full_name,phone_number,email,address1,address2,city,country,state
+SomeVaultItemName,https://example.com,hello@bitwarden.com,someStrongPassword,Some note for the VaultItem,,,,,,SomeFolderForVaultItem,,,,,,,,`;

spec/common/importers/testData/nordpassCsv/nordpass.secureNote.csv.ts

@@ -0,0 +1,3 @@
+export const data = `name,url,username,password,note,cardholdername,cardnumber,cvc,expirydate,zipcode,folder,full_name,phone_number,email,address1,address2,city,country,state
+notesFolder,,,,,,,,,,,,,,,,,,
+MySuperSecureNoteTitle,,,,MySuperSecureNote,,,,,,notesFolder,,,,,,,,`;