1
0
mirror of https://github.com/bitwarden/browser synced 2025-12-17 00:33:44 +00:00

Add support to import from Nordpass(.csv) (#360)

* Add support for parsing .csv files from Nordpass

* Remove whitespace before extracting CardExpiration

* Add curlybraces to one-liner if's as requested

* NordPassImporter: Process more complex names
This commit is contained in:
Daniel James Smith
2021-04-29 12:51:35 +02:00
committed by GitHub
parent e298ecfee3
commit 1eb40a4891
8 changed files with 342 additions and 0 deletions

View File

@@ -241,6 +241,7 @@ export abstract class BaseImporter {
protected setCardExpiration(cipher: CipherView, expiration: string): boolean {
if (!this.isNullOrWhitespace(expiration)) {
expiration = expiration.replace(/\s/g, '');
const parts = expiration.split('/');
if (parts.length === 2) {
let month: string = null;

View File

@@ -0,0 +1,149 @@
import { BaseImporter } from './baseImporter';
import { Importer } from './importer';
import { ImportResult } from '../models/domain/importResult';
import { CipherView } from '../models/view/cipherView';
import { LoginView } from '../models/view/loginView';
import { CipherType } from '../enums/cipherType';
import { SecureNoteType } from '../enums/secureNoteType';
type nodePassCsvParsed = {
name: string;
url: string;
username: string;
password: string;
note: string;
cardholdername: string;
cardnumber: string;
cvc: string;
expirydate: string;
zipcode: string;
folder: string;
full_name: string;
phone_number: string;
email: string;
address1: string;
address2: string;
city: string;
country: string;
state: string;
};
export class NordPassCsvImporter extends BaseImporter implements Importer {
parse(data: string): Promise<ImportResult> {
const result = new ImportResult();
const results: nodePassCsvParsed[] = this.parseCsv(data, true);
if (results == null) {
result.success = false;
return Promise.resolve(result);
}
results.forEach(record => {
const recordType = this.evaluateType(record);
if (recordType === undefined) {
return;
}
if (!this.organization) {
this.processFolder(result, record.folder);
}
const cipher = new CipherView();
cipher.name = this.getValueOrDefault(record.name, '--');
cipher.notes = this.getValueOrDefault(record.note);
switch (recordType) {
case CipherType.Login:
cipher.type = CipherType.Login;
cipher.login = new LoginView();
cipher.login.username = this.getValueOrDefault(record.username);
cipher.login.password = this.getValueOrDefault(record.password);
cipher.login.uris = this.makeUriArray(record.url);
break;
case CipherType.Card:
cipher.type = CipherType.Card;
cipher.card.cardholderName = this.getValueOrDefault(record.cardholdername);
cipher.card.number = this.getValueOrDefault(record.cardnumber);
cipher.card.code = this.getValueOrDefault(record.cvc);
cipher.card.brand = this.getCardBrand(cipher.card.number);
this.setCardExpiration(cipher, record.expirydate);
break;
case CipherType.Identity:
cipher.type = CipherType.Identity;
this.processName(cipher, this.getValueOrDefault(record.full_name));
cipher.identity.address1 = this.getValueOrDefault(record.address1);
cipher.identity.address2 = this.getValueOrDefault(record.address2);
cipher.identity.city = this.getValueOrDefault(record.city);
cipher.identity.state = this.getValueOrDefault(record.state);
cipher.identity.postalCode = this.getValueOrDefault(record.zipcode);
cipher.identity.country = this.getValueOrDefault(record.country);
if (cipher.identity.country != null) {
cipher.identity.country = cipher.identity.country.toUpperCase();
}
cipher.identity.email = this.getValueOrDefault(record.email);
cipher.identity.phone = this.getValueOrDefault(record.phone_number);
break;
case CipherType.SecureNote:
cipher.type = CipherType.SecureNote;
cipher.secureNote.type = SecureNoteType.Generic;
break;
default:
break;
}
this.cleanupCipher(cipher);
result.ciphers.push(cipher);
});
if (this.organization) {
this.moveFoldersToCollections(result);
}
result.success = true;
return Promise.resolve(result);
}
private evaluateType(record: nodePassCsvParsed): CipherType {
if (!this.isNullOrWhitespace(record.username)) {
return CipherType.Login;
}
if (!this.isNullOrWhitespace(record.cardnumber)) {
return CipherType.Card;
}
if (!this.isNullOrWhitespace(record.full_name)) {
return CipherType.Identity;
}
if (!this.isNullOrWhitespace(record.note)) {
return CipherType.SecureNote;
}
return undefined;
}
private processName(cipher: CipherView, fullName: string) {
if (this.isNullOrWhitespace(fullName)) {
return;
}
const nameParts = fullName.split(' ');
if (nameParts.length > 0) {
cipher.identity.firstName = this.getValueOrDefault(nameParts[0]);
}
if (nameParts.length === 2) {
cipher.identity.lastName = this.getValueOrDefault(nameParts[1]);
} else if (nameParts.length >= 3) {
cipher.identity.middleName = this.getValueOrDefault(nameParts[1]);
cipher.identity.lastName = nameParts.slice(2, nameParts.length).join(' ');
}
}
}

View File

@@ -54,6 +54,7 @@ import { LogMeOnceCsvImporter } from '../importers/logMeOnceCsvImporter';
import { MeldiumCsvImporter } from '../importers/meldiumCsvImporter';
import { MSecureCsvImporter } from '../importers/msecureCsvImporter';
import { MykiCsvImporter } from '../importers/mykiCsvImporter';
import { NordPassCsvImporter } from '../importers/nordpassCsvImporter';
import { OnePassword1PifImporter } from '../importers/onepasswordImporters/onepassword1PifImporter';
import { OnePasswordMacCsvImporter } from '../importers/onepasswordImporters/onepasswordMacCsvImporter';
import { OnePasswordWinCsvImporter } from '../importers/onepasswordImporters/onepasswordWinCsvImporter';
@@ -137,6 +138,7 @@ export class ImportService implements ImportServiceAbstraction {
{ id: 'codebookcsv', name: 'Codebook (csv)' },
{ id: 'encryptrcsv', name: 'Encryptr (csv)' },
{ id: 'yoticsv', name: 'Yoti (csv)' },
{ id: 'nordpasscsv', name: 'Nordpass (csv)' },
];
constructor(private cipherService: CipherService, private folderService: FolderService,
@@ -294,6 +296,8 @@ export class ImportService implements ImportServiceAbstraction {
return new EncryptrCsvImporter();
case 'yoticsv':
return new YotiCsvImporter();
case 'nordpasscsv':
return new NordPassCsvImporter();
default:
return null;
}