bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-20 18:23:31 +00:00
Code Issues Releases Wiki Activity

[PM-1674] let node-ipc use individual pipes on Windows (#4020)

Browse Source 
* let node-ipc use individual pipes on Windows

This fixes an issue with multiple users on Windows. There should be an individual Windows pipe used for communication between browser plugin and desktop for each user. However, the naming scheme used the same name for every user. This change adds some uniqueness with a hash over username and unique directory name.

* Fix ipc socket root for native-messaging too

* use only homedir as unique
This commit is contained in:
Andre Herms
2023-04-11 16:45:24 +02:00
committed by GitHub
parent 8d34bc9ad9
commit 1f026da924
2 changed files with 31 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
apps/desktop/src/main/native-messaging.main.ts
View File

@@ -6,6 +6,7 @@ import * as util from "util";
import { ipcMain } from "electron";
import * as ipc from "node-ipc";
import { getIpcSocketRoot } from "../proxy/ipc";
import { LogService } from "@bitwarden/common/abstractions/log.service";
@@ -25,11 +26,9 @@ export class NativeMessagingMain {
async listen() {
ipc.config.id = "bitwarden";
ipc.config.retry = 1500;
if (process.platform === "darwin") {
if (!existsSync(`${homedir()}/tmp`)) {
await fs.mkdir(`${homedir()}/tmp`);
}
ipc.config.socketRoot = `${homedir()}/tmp/`;
const ipcSocketRoot = getIpcSocketRoot();
if (ipcSocketRoot != null) {
ipc.config.socketRoot = ipcSocketRoot;
}
ipc.serve(() => {