bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-16 08:13:42 +00:00
Code Issues Releases Wiki Activity

[PM-3704] Autofill Command Should Not Attempt to Fill If Fields Are Not Found in Page Details (#6318)

Browse Source 
* [PM-3704] Autofil Command Should Not Attempt to Fill If Fields Are Not Found in Page Details

* [PM-2319] Adding jest test to ensure workflow is captured in future refactors
This commit is contained in:
Cesar Gonzalez
2023-09-30 13:25:01 -05:00
committed by GitHub
parent a42cea8570
commit 20564f2f54
2 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
apps/browser/src/autofill/services/autofill.service.spec.ts
View File

@@ -780,6 +780,18 @@ describe("AutofillService", () => {
]; ];
}); });
it("returns a null vault without doing autofill if the page details does not contain fields ", async () => {
pageDetails[0].details.fields = [];
jest.spyOn(autofillService as any, "getActiveTab");
jest.spyOn(autofillService, "doAutoFill");
const result = await autofillService.doAutoFillActiveTab(pageDetails, false);
expect(autofillService["getActiveTab"]).not.toHaveBeenCalled();
expect(autofillService.doAutoFill).not.toHaveBeenCalled();
expect(result).toBeNull();
});
it("returns a null value without doing autofill if the active tab cannot be found", async () => { it("returns a null value without doing autofill if the active tab cannot be found", async () => {
jest.spyOn(autofillService as any, "getActiveTab").mockResolvedValueOnce(undefined); jest.spyOn(autofillService as any, "getActiveTab").mockResolvedValueOnce(undefined);
jest.spyOn(autofillService, "doAutoFill"); jest.spyOn(autofillService, "doAutoFill");

4
apps/browser/src/autofill/services/autofill.service.ts
View File

@@ -314,6 +314,10 @@ export default class AutofillService implements AutofillServiceInterface {
fromCommand: boolean, fromCommand: boolean,
cipherType?: CipherType cipherType?: CipherType
): Promise<string | null> { ): Promise<string | null> {
if (!pageDetails[0]?.details?.fields?.length) {
return null;
}
const tab = await this.getActiveTab(); const tab = await this.getActiveTab();
if (!tab || !tab.url) { if (!tab || !tab.url) {