bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-16 16:23:44 +00:00
Code Issues Releases Wiki Activity

Autofill - Prefer signal & change detection (#16943)

Browse Source
This commit is contained in:
Oscar Hinton
2025-10-22 22:06:05 +02:00
committed by GitHub
parent 8154613462
commit 2147f74ae8
7 changed files with 24 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
apps/browser/src/autofill/popup/fido2/fido2-cipher-row.component.ts
View File

@@ -28,9 +28,17 @@ import {
], ],
}) })
export class Fido2CipherRowComponent { export class Fido2CipherRowComponent {
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-output-emitter-ref
@Output() onSelected = new EventEmitter<CipherView>(); @Output() onSelected = new EventEmitter<CipherView>();
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@Input() cipher: CipherView; @Input() cipher: CipherView;
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@Input() last: boolean; @Input() last: boolean;
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@Input() title: string; @Input() title: string;
protected selectCipher(c: CipherView) { protected selectCipher(c: CipherView) {

2
apps/browser/src/autofill/popup/fido2/fido2-use-browser-link.component.ts
View File

@@ -15,6 +15,8 @@ import { MenuModule } from "@bitwarden/components";
import { fido2PopoutSessionData$ } from "../../../vault/popup/utils/fido2-popout-session-data"; import { fido2PopoutSessionData$ } from "../../../vault/popup/utils/fido2-popout-session-data";
import { BrowserFido2UserInterfaceSession } from "../../fido2/services/browser-fido2-user-interface.service"; import { BrowserFido2UserInterfaceSession } from "../../fido2/services/browser-fido2-user-interface.service";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({ @Component({
selector: "app-fido2-use-browser-link", selector: "app-fido2-use-browser-link",
templateUrl: "fido2-use-browser-link.component.html", templateUrl: "fido2-use-browser-link.component.html",

2
apps/browser/src/autofill/popup/fido2/fido2.component.ts
View File

@@ -71,6 +71,8 @@ interface ViewData {
fallbackSupported: boolean; fallbackSupported: boolean;
} }
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({ @Component({
selector: "app-fido2", selector: "app-fido2",
templateUrl: "fido2.component.html", templateUrl: "fido2.component.html",

2
apps/browser/src/autofill/popup/settings/autofill.component.ts
View File

@@ -77,6 +77,8 @@ import { PopOutComponent } from "../../../platform/popup/components/pop-out.comp
import { PopupHeaderComponent } from "../../../platform/popup/layout/popup-header.component"; import { PopupHeaderComponent } from "../../../platform/popup/layout/popup-header.component";
import { PopupPageComponent } from "../../../platform/popup/layout/popup-page.component"; import { PopupPageComponent } from "../../../platform/popup/layout/popup-page.component";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({ @Component({
templateUrl: "autofill.component.html", templateUrl: "autofill.component.html",
imports: [ imports: [

4
apps/browser/src/autofill/popup/settings/blocked-domains.component.ts
View File

@@ -41,6 +41,8 @@ import { PopupHeaderComponent } from "../../../platform/popup/layout/popup-heade
import { PopupPageComponent } from "../../../platform/popup/layout/popup-page.component"; import { PopupPageComponent } from "../../../platform/popup/layout/popup-page.component";
import { PopupRouterCacheService } from "../../../platform/popup/view-cache/popup-router-cache.service"; import { PopupRouterCacheService } from "../../../platform/popup/view-cache/popup-router-cache.service";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({ @Component({
selector: "app-blocked-domains", selector: "app-blocked-domains",
templateUrl: "blocked-domains.component.html", templateUrl: "blocked-domains.component.html",
@@ -66,6 +68,8 @@ import { PopupRouterCacheService } from "../../../platform/popup/view-cache/popu
], ],
}) })
export class BlockedDomainsComponent implements AfterViewInit, OnDestroy { export class BlockedDomainsComponent implements AfterViewInit, OnDestroy {
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@ViewChildren("uriInput") uriInputElements: QueryList<ElementRef<HTMLInputElement>> = @ViewChildren("uriInput") uriInputElements: QueryList<ElementRef<HTMLInputElement>> =
new QueryList(); new QueryList();

4
apps/browser/src/autofill/popup/settings/excluded-domains.component.ts
View File

@@ -42,6 +42,8 @@ import { PopupHeaderComponent } from "../../../platform/popup/layout/popup-heade
import { PopupPageComponent } from "../../../platform/popup/layout/popup-page.component"; import { PopupPageComponent } from "../../../platform/popup/layout/popup-page.component";
import { PopupRouterCacheService } from "../../../platform/popup/view-cache/popup-router-cache.service"; import { PopupRouterCacheService } from "../../../platform/popup/view-cache/popup-router-cache.service";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({ @Component({
selector: "app-excluded-domains", selector: "app-excluded-domains",
templateUrl: "excluded-domains.component.html", templateUrl: "excluded-domains.component.html",
@@ -67,6 +69,8 @@ import { PopupRouterCacheService } from "../../../platform/popup/view-cache/popu
], ],
}) })
export class ExcludedDomainsComponent implements AfterViewInit, OnDestroy { export class ExcludedDomainsComponent implements AfterViewInit, OnDestroy {
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@ViewChildren("uriInput") uriInputElements: QueryList<ElementRef<HTMLInputElement>> = @ViewChildren("uriInput") uriInputElements: QueryList<ElementRef<HTMLInputElement>> =
new QueryList(); new QueryList();

2
apps/browser/src/autofill/popup/settings/notifications.component.ts
View File

@@ -21,6 +21,8 @@ import { PopOutComponent } from "../../../platform/popup/components/pop-out.comp
import { PopupHeaderComponent } from "../../../platform/popup/layout/popup-header.component"; import { PopupHeaderComponent } from "../../../platform/popup/layout/popup-header.component";
import { PopupPageComponent } from "../../../platform/popup/layout/popup-page.component"; import { PopupPageComponent } from "../../../platform/popup/layout/popup-page.component";
// FIXME(https://bitwarden.atlassian.net/browse/CL-764): Migrate to OnPush
// eslint-disable-next-line @angular-eslint/prefer-on-push-component-change-detection
@Component({ @Component({
templateUrl: "notifications.component.html", templateUrl: "notifications.component.html",
imports: [ imports: [