bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-15 07:43:35 +00:00
Code Issues Releases Wiki Activity

[PM-5189] Fixing issue found in Safari with how the inline menu is re-positioned

Browse Source
This commit is contained in:
Cesar Gonzalez
2024-06-17 10:56:07 -05:00
parent ee8b179b6c
commit 22299ce4fb
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
apps/browser/src/autofill/services/autofill-overlay-content.service.ts
View File

@@ -1133,10 +1133,14 @@ export class AutofillOverlayContentService implements AutofillOverlayContentServ
*/ */
private isFocusedFieldWithinViewportBounds() { private isFocusedFieldWithinViewportBounds() {
const focusedFieldRectsTop = this.focusedFieldData?.focusedFieldRects?.top; const focusedFieldRectsTop = this.focusedFieldData?.focusedFieldRects?.top;
const focusedFieldRectsBottom =
focusedFieldRectsTop + this.focusedFieldData?.focusedFieldRects?.height;
const viewportHeight = globalThis.innerHeight + globalThis.scrollY;
return ( return (
focusedFieldRectsTop && focusedFieldRectsTop &&
focusedFieldRectsTop > 0 && focusedFieldRectsTop > 0 &&
focusedFieldRectsTop < globalThis.innerHeight + globalThis.scrollY focusedFieldRectsTop < viewportHeight &&
focusedFieldRectsBottom < viewportHeight
); );
} }