diff --git a/apps/browser/src/_locales/en/messages.json b/apps/browser/src/_locales/en/messages.json index 0e4c0da2452..92fabdae3ee 100644 --- a/apps/browser/src/_locales/en/messages.json +++ b/apps/browser/src/_locales/en/messages.json @@ -3234,9 +3234,6 @@ } } }, - "loggingInOn": { - "message": "Logging in on" - }, "opensInANewWindow": { "message": "Opens in a new window" }, diff --git a/apps/browser/src/auth/popup/settings/account-security-v1.component.ts b/apps/browser/src/auth/popup/settings/account-security-v1.component.ts index db45b3adb73..9d8a2ac4c88 100644 --- a/apps/browser/src/auth/popup/settings/account-security-v1.component.ts +++ b/apps/browser/src/auth/popup/settings/account-security-v1.component.ts @@ -57,7 +57,7 @@ export class AccountSecurityComponent implements OnInit, OnDestroy { availableVaultTimeoutActions: VaultTimeoutAction[] = []; vaultTimeoutOptions: VaultTimeoutOption[]; vaultTimeoutPolicyCallout: Observable<{ - timeout: { hours: number; minutes: number }; + timeout: { hours: string; minutes: string }; action: VaultTimeoutAction; }>; supportsBiometric: boolean; @@ -105,8 +105,8 @@ export class AccountSecurityComponent implements OnInit, OnDestroy { let timeout; if (policy.data?.minutes) { timeout = { - hours: Math.floor(policy.data?.minutes / 60), - minutes: policy.data?.minutes % 60, + hours: Math.floor(policy.data?.minutes / 60).toString(), + minutes: (policy.data?.minutes % 60).toString(), }; } return { timeout: timeout, action: policy.data?.action }; diff --git a/apps/browser/src/autofill/background/overlay.background.spec.ts b/apps/browser/src/autofill/background/overlay.background.spec.ts index ebd73fa4cc0..d59ed447dde 100644 --- a/apps/browser/src/autofill/background/overlay.background.spec.ts +++ b/apps/browser/src/autofill/background/overlay.background.spec.ts @@ -629,6 +629,9 @@ describe("OverlayBackground", () => { it("skips updating the inline menu list if the user has the inline menu set to open on button click", async () => { inlineMenuVisibilityMock$.next(AutofillOverlayVisibility.OnButtonClick); + jest + .spyOn(overlayBackground as any, "checkIsInlineMenuListVisible") + .mockReturnValue(false); tabsSendMessageSpy.mockImplementation((_tab, message, _options) => { if (message.command === "checkFocusedFieldHasValue") { return Promise.resolve(true); diff --git a/apps/browser/src/autofill/background/overlay.background.ts b/apps/browser/src/autofill/background/overlay.background.ts index 6fb4589baa1..41791b3b75f 100644 --- a/apps/browser/src/autofill/background/overlay.background.ts +++ b/apps/browser/src/autofill/background/overlay.background.ts @@ -1009,7 +1009,10 @@ export class OverlayBackground implements OverlayBackgroundInterface { this.logService.error(error), ); - if ((await this.getInlineMenuVisibility()) === AutofillOverlayVisibility.OnButtonClick) { + if ( + !this.checkIsInlineMenuListVisible() && + (await this.getInlineMenuVisibility()) === AutofillOverlayVisibility.OnButtonClick + ) { return; } @@ -2579,7 +2582,7 @@ export class OverlayBackground implements OverlayBackgroundInterface { * @param sender */ private resetFocusedFieldSubFrameOffsets(sender: chrome.runtime.MessageSender) { - if (this.focusedFieldData.frameId > 0 && this.subFrameOffsetsForTab[sender.tab.id]) { + if (this.focusedFieldData?.frameId > 0 && this.subFrameOffsetsForTab[sender.tab.id]) { this.subFrameOffsetsForTab[sender.tab.id].set(this.focusedFieldData.frameId, null); } } @@ -2592,6 +2595,7 @@ export class OverlayBackground implements OverlayBackgroundInterface { */ private async triggerSubFrameFocusInRebuild(sender: chrome.runtime.MessageSender) { this.cancelInlineMenuFadeInAndPositionUpdate(); + this.resetFocusedFieldSubFrameOffsets(sender); this.rebuildSubFrameOffsets$.next(sender); this.repositionInlineMenu$.next(sender); } diff --git a/apps/desktop/package.json b/apps/desktop/package.json index 1c1d7d88312..8c89da0e85f 100644 --- a/apps/desktop/package.json +++ b/apps/desktop/package.json @@ -1,7 +1,7 @@ { "name": "@bitwarden/desktop", "description": "A secure and free password manager for all of your devices.", - "version": "2024.10.2", + "version": "2024.10.3", "keywords": [ "bitwarden", "password", diff --git a/apps/desktop/src/locales/en/messages.json b/apps/desktop/src/locales/en/messages.json index 414f254e7ad..83aaf2157d7 100644 --- a/apps/desktop/src/locales/en/messages.json +++ b/apps/desktop/src/locales/en/messages.json @@ -2804,9 +2804,6 @@ "message": "EU", "description": "European Union" }, - "loggingInOn": { - "message": "Logging in on" - }, "selfHostedServer": { "message": "self-hosted" }, diff --git a/apps/desktop/src/package-lock.json b/apps/desktop/src/package-lock.json index da48e903e3e..092a8c97618 100644 --- a/apps/desktop/src/package-lock.json +++ b/apps/desktop/src/package-lock.json @@ -1,12 +1,12 @@ { "name": "@bitwarden/desktop", - "version": "2024.10.2", + "version": "2024.10.3", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@bitwarden/desktop", - "version": "2024.10.2", + "version": "2024.10.3", "license": "GPL-3.0", "dependencies": { "@bitwarden/desktop-napi": "file:../desktop_native/napi", diff --git a/apps/desktop/src/package.json b/apps/desktop/src/package.json index 72d77b71b4f..5e27de5f415 100644 --- a/apps/desktop/src/package.json +++ b/apps/desktop/src/package.json @@ -2,7 +2,7 @@ "name": "@bitwarden/desktop", "productName": "Bitwarden", "description": "A secure and free password manager for all of your devices.", - "version": "2024.10.2", + "version": "2024.10.3", "author": "Bitwarden Inc. (https://bitwarden.com)", "homepage": "https://bitwarden.com", "license": "GPL-3.0", diff --git a/apps/web/src/locales/en/messages.json b/apps/web/src/locales/en/messages.json index eead4fd80d6..aa7bce04312 100644 --- a/apps/web/src/locales/en/messages.json +++ b/apps/web/src/locales/en/messages.json @@ -1583,38 +1583,6 @@ "specialCharacters": { "message": "Special characters (!@#$%^&*)" }, - "uppercaseDescription": { - "message": "Include uppercase characters", - "description": "Tooltip for the password generator uppercase character checkbox" - }, - "uppercaseLabel": { - "message": "A-Z", - "description": "Label for the password generator uppercase character checkbox" - }, - "lowercaseDescription": { - "message": "Include lowercase characters", - "description": "Full description for the password generator lowercase character checkbox" - }, - "lowercaseLabel": { - "message": "a-z", - "description": "Label for the password generator lowercase character checkbox" - }, - "numbersDescription": { - "message": "Include numbers", - "description": "Full description for the password generator numbers checkbox" - }, - "numbersLabel": { - "message": "0-9", - "description": "Label for the password generator numbers checkbox" - }, - "specialCharactersDescription": { - "message": "Include special characters", - "description": "Full description for the password generator special characters checkbox" - }, - "specialCharactersLabel": { - "message": "!@#$%^&*", - "description": "Label for the password generator special characters checkbox" - }, "numWords": { "message": "Number of words" }, @@ -9529,10 +9497,6 @@ "message": "!@#$%^&*", "description": "Label for the password generator special characters checkbox" }, - "avoidAmbiguous": { - "message": "Avoid ambiguous characters", - "description": "Label for the avoid ambiguous characters checkbox." - }, "addAttachment": { "message": "Add attachment" }, diff --git a/libs/angular/src/auth/components/environment-selector.component.html b/libs/angular/src/auth/components/environment-selector.component.html index 673f6479849..6a93e2a221a 100644 --- a/libs/angular/src/auth/components/environment-selector.component.html +++ b/libs/angular/src/auth/components/environment-selector.component.html @@ -4,7 +4,7 @@ } as data" >
- {{ "loggingInOn" | i18n }}: + {{ "accessing" | i18n }}: