bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-17 00:33:44 +00:00
Code Issues Releases Wiki Activity

[PM-12303] fix password state spurious emissions (#11670)

Browse Source 
* trace generation requests
* eliminate spurious save caused by validator changes
* fix emissions caused by setting bounds attrbutes
---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
This commit is contained in:
✨ Audrey ✨
2024-10-23 14:23:28 -04:00
committed by GitHub
parent 7c79487f04
commit 22be52d2f3
11 changed files with 64 additions and 91 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
libs/tools/generator/components/src/passphrase-settings.component.ts
View File

@@ -91,9 +91,8 @@ export class PassphraseSettingsComponent implements OnInit, OnDestroy {
.get(Controls.wordSeparator)
.setValidators(toValidators(Controls.wordSeparator, Generators.passphrase, constraints));
// forward word boundaries to the template (can't do it through the rx form)
this.minNumWords = constraints.numWords.min;
this.maxNumWords = constraints.numWords.max;
this.settings.updateValueAndValidity({ emitEvent: false });
this.policyInEffect = constraints.policyInEffect;
this.toggleEnabled(Controls.capitalize, !constraints.capitalize?.readonly);
@@ -104,12 +103,6 @@ export class PassphraseSettingsComponent implements OnInit, OnDestroy {
this.settings.valueChanges.pipe(takeUntil(this.destroyed$)).subscribe(settings);
}
/** attribute binding for numWords[min] */
protected minNumWords: number;
/** attribute binding for numWords[max] */
protected maxNumWords: number;
/** display binding for enterprise policy notice */
protected policyInEffect: boolean;