bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-06 00:13:28 +00:00
Code Issues Releases Wiki Activity

[CL-846] forbid hardcoded colors in svg (#16167)

Browse Source 
* add eslint rule to prevent hardcoded colors in svgs

* add tests

* warn instead of error for now
This commit is contained in:
Will Martin
2025-09-10 22:22:39 -04:00
committed by GitHub
parent 2894e40f2d
commit 22cf55a23f
4 changed files with 129 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
eslint.config.mjs
View File

@@ -35,6 +35,7 @@ export default tseslint.config(
rxjs: fixupPluginRules(rxjs),
"rxjs-angular": fixupPluginRules(angularRxjs),
"@bitwarden/platform": platformPlugins,
"@bitwarden/components": componentPlugins,
},
languageOptions: {
parserOptions: {
@@ -74,8 +75,11 @@ export default tseslint.config(
"@angular-eslint/prefer-standalone": 0,
"@angular-eslint/use-lifecycle-interface": "error",
"@angular-eslint/use-pipe-transform-interface": 0,
"@bitwarden/platform/required-using": "error",
"@bitwarden/platform/no-enums": "error",
"@bitwarden/components/require-theme-colors-in-svg": "warn",
"@typescript-eslint/explicit-member-accessibility": ["error", { accessibility: "no-public" }],
"@typescript-eslint/no-explicit-any": "off", // TODO: This should be re-enabled
"@typescript-eslint/no-floating-promises": "error",