bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-10 13:23:34 +00:00
Code Issues Releases Wiki Activity

fix: move feature flag to correct grouping, update casing, update callers, refs PM-17763 (#13184)

Browse Source
This commit is contained in:
Vincent Salucci
2025-01-31 12:18:17 -06:00
committed by GitHub
parent 8e70d5b923
commit 22edfd4283
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/web/src/app/admin-console/organizations/settings/account.component.ts
View File

@@ -106,7 +106,7 @@ export class AccountComponent implements OnInit, OnDestroy {
this.selfHosted = this.platformUtilsService.isSelfHost(); this.selfHosted = this.platformUtilsService.isSelfHost();
this.configService this.configService
.getFeatureFlag$(FeatureFlag.limitItemDeletion) .getFeatureFlag$(FeatureFlag.LimitItemDeletion)
.pipe(takeUntil(this.destroy$)) .pipe(takeUntil(this.destroy$))
.subscribe((isAble) => (this.limitItemDeletionFeatureFlagIsEnabled = isAble)); .subscribe((isAble) => (this.limitItemDeletionFeatureFlagIsEnabled = isAble));

4
libs/common/src/enums/feature-flag.enum.ts
View File

@@ -9,6 +9,7 @@ export enum FeatureFlag {
AccountDeprovisioning = "pm-10308-account-deprovisioning", AccountDeprovisioning = "pm-10308-account-deprovisioning",
VerifiedSsoDomainEndpoint = "pm-12337-refactor-sso-details-endpoint", VerifiedSsoDomainEndpoint = "pm-12337-refactor-sso-details-endpoint",
PM14505AdminConsoleIntegrationPage = "pm-14505-admin-console-integration-page", PM14505AdminConsoleIntegrationPage = "pm-14505-admin-console-integration-page",
LimitItemDeletion = "pm-15493-restrict-item-deletion-to-can-manage-permission",
/* Autofill */ /* Autofill */
BlockBrowserInjectionsByDomain = "block-browser-injections-by-domain", BlockBrowserInjectionsByDomain = "block-browser-injections-by-domain",
@@ -48,7 +49,6 @@ export enum FeatureFlag {
ResellerManagedOrgAlert = "PM-15814-alert-owners-of-reseller-managed-orgs", ResellerManagedOrgAlert = "PM-15814-alert-owners-of-reseller-managed-orgs",
NewDeviceVerification = "new-device-verification", NewDeviceVerification = "new-device-verification",
EnableRiskInsightsNotifications = "enable-risk-insights-notifications", EnableRiskInsightsNotifications = "enable-risk-insights-notifications",
limitItemDeletion = "pm-15493-restrict-item-deletion-to-can-manage-permission",
} }
export type AllowedFeatureFlagTypes = boolean | number | string; export type AllowedFeatureFlagTypes = boolean | number | string;
@@ -68,6 +68,7 @@ export const DefaultFeatureFlagValue = {
[FeatureFlag.AccountDeprovisioning]: FALSE, [FeatureFlag.AccountDeprovisioning]: FALSE,
[FeatureFlag.VerifiedSsoDomainEndpoint]: FALSE, [FeatureFlag.VerifiedSsoDomainEndpoint]: FALSE,
[FeatureFlag.PM14505AdminConsoleIntegrationPage]: FALSE, [FeatureFlag.PM14505AdminConsoleIntegrationPage]: FALSE,
[FeatureFlag.LimitItemDeletion]: FALSE,
/* Autofill */ /* Autofill */
[FeatureFlag.BlockBrowserInjectionsByDomain]: FALSE, [FeatureFlag.BlockBrowserInjectionsByDomain]: FALSE,
@@ -107,7 +108,6 @@ export const DefaultFeatureFlagValue = {
[FeatureFlag.ResellerManagedOrgAlert]: FALSE, [FeatureFlag.ResellerManagedOrgAlert]: FALSE,
[FeatureFlag.NewDeviceVerification]: FALSE, [FeatureFlag.NewDeviceVerification]: FALSE,
[FeatureFlag.EnableRiskInsightsNotifications]: FALSE, [FeatureFlag.EnableRiskInsightsNotifications]: FALSE,
[FeatureFlag.limitItemDeletion]: FALSE,
} satisfies Record<FeatureFlag, AllowedFeatureFlagTypes>; } satisfies Record<FeatureFlag, AllowedFeatureFlagTypes>;
export type DefaultFeatureFlagValueType = typeof DefaultFeatureFlagValue; export type DefaultFeatureFlagValueType = typeof DefaultFeatureFlagValue;