bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-12 22:33:35 +00:00
Code Issues Releases Wiki Activity

remove dependency on cipher decryption keys (#14408)

Browse Source 
- It was not being used in the observable pipeline and causing multiple decryptions
This commit is contained in:
Nick Krantz
2025-04-24 15:34:04 -05:00
committed by GitHub
parent 4a01c8bb17
commit 241cbf8cc9
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
libs/common/src/vault/services/cipher.service.ts
View File

@@ -124,12 +124,8 @@ export class CipherService implements CipherServiceAbstraction {
* decryption is in progress. The latest decrypted ciphers will be emitted once decryption is complete. * decryption is in progress. The latest decrypted ciphers will be emitted once decryption is complete.
*/ */
cipherViews$ = perUserCache$((userId: UserId): Observable<CipherView[] | null> => { cipherViews$ = perUserCache$((userId: UserId): Observable<CipherView[] | null> => {
return combineLatest([ return combineLatest([this.encryptedCiphersState(userId).state$, this.localData$(userId)]).pipe(
this.encryptedCiphersState(userId).state$, filter(([ciphers]) => ciphers != null), // Skip if ciphers haven't been loaded yor synced yet
this.localData$(userId),
this.keyService.cipherDecryptionKeys$(userId, true),
]).pipe(
filter(([ciphers, keys]) => ciphers != null && keys != null), // Skip if ciphers haven't been loaded yor synced yet
switchMap(() => this.getAllDecrypted(userId)), switchMap(() => this.getAllDecrypted(userId)),
); );
}, this.clearCipherViewsForUser$); }, this.clearCipherViewsForUser$);