From 2453eaeaf8101f15c611cd56c49f50fd8c8c1bf9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Anders=20=C3=85berg?= Date: Tue, 11 Mar 2025 14:15:13 +0100 Subject: [PATCH] Fixed lint --- apps/desktop/src/app/components/fido2placeholder.component.ts | 2 +- .../autofill/services/desktop-fido2-user-interface.service.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/apps/desktop/src/app/components/fido2placeholder.component.ts b/apps/desktop/src/app/components/fido2placeholder.component.ts index e4249b26c27..b95dcc6d890 100644 --- a/apps/desktop/src/app/components/fido2placeholder.component.ts +++ b/apps/desktop/src/app/components/fido2placeholder.component.ts @@ -104,7 +104,7 @@ export class Fido2PlaceholderComponent implements OnInit, OnDestroy { // But if this route is somehow opened outside of session we want to make sure we clean up? await this.router.navigate(["/"]); await this.desktopSettingsService.setModalMode(false); - } catch (error) { + } catch { // TODO: Handle error appropriately } } diff --git a/apps/desktop/src/autofill/services/desktop-fido2-user-interface.service.ts b/apps/desktop/src/autofill/services/desktop-fido2-user-interface.service.ts index b83d8b5d8cd..3caf13fa5b7 100644 --- a/apps/desktop/src/autofill/services/desktop-fido2-user-interface.service.ts +++ b/apps/desktop/src/autofill/services/desktop-fido2-user-interface.service.ts @@ -31,7 +31,7 @@ import { LoginUriView } from "@bitwarden/common/vault/models/view/login-uri.view import { LoginView } from "@bitwarden/common/vault/models/view/login.view"; import { SecureNoteView } from "@bitwarden/common/vault/models/view/secure-note.view"; -import { DesktopSettingsService } from "src/platform/services/desktop-settings.service"; +import { DesktopSettingsService } from "../../platform/services/desktop-settings.service"; /** * This type is used to pass the window position from the native UI @@ -162,7 +162,7 @@ export class DesktopFido2UserInterfaceSession implements Fido2UserInterfaceSessi ): Promise<{ cipherId: string; userVerified: boolean } | undefined> { try { return await lastValueFrom(this.chosenCipherSubject.pipe(timeout(timeoutMs))); - } catch (error) { + } catch { // If we hit a timeout, return undefined instead of throwing this.logService.warning("Timeout: User did not select a cipher within the allowed time", { timeoutMs,