bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-21 02:33:46 +00:00
Code Issues Releases Wiki Activity

Prefer get methods to return single user states unless specified active (#7834)

Browse Source 
* Prefer get methods to return single user states unless specified active

* Improve comment
This commit is contained in:
Matt Gibson
2024-02-08 12:02:48 -05:00
committed by GitHub
parent 4be25e3df3
commit 2525a3707f
4 changed files with 52 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
libs/common/spec/fake-account-service.ts
View File

@@ -48,32 +48,24 @@ export class FakeAccountService implements AccountService {
}
async addAccount(userId: UserId, accountData: AccountInfo): Promise<void> {
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this.mock.addAccount(userId, accountData);
const current = this.accountsSubject["_buffer"][0] ?? {};
this.accountsSubject.next({ ...current, [userId]: accountData });
await this.mock.addAccount(userId, accountData);
}
async setAccountName(userId: UserId, name: string): Promise<void> {
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this.mock.setAccountName(userId, name);
await this.mock.setAccountName(userId, name);
}
async setAccountEmail(userId: UserId, email: string): Promise<void> {
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this.mock.setAccountEmail(userId, email);
await this.mock.setAccountEmail(userId, email);
}
async setAccountStatus(userId: UserId, status: AuthenticationStatus): Promise<void> {
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this.mock.setAccountStatus(userId, status);
await this.mock.setAccountStatus(userId, status);
}
async switchAccount(userId: UserId): Promise<void> {
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this.mock.switchAccount(userId);
await this.mock.switchAccount(userId);
}
}