bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-15 15:53:27 +00:00
Code Issues Releases Wiki Activity

Merge pull request #1339 from bitwarden/fix/safari-app-crash-2

Browse Source 
Fix completion handler nil crashes SFSafariWindow
This commit is contained in:
Chad Scharf
2020-07-22 18:34:57 -04:00
committed by GitHub
parent f024441b6c 8f032fd03d
commit 25f2697dd2
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/safari/safari/SafariExtensionViewController.swift
View File

@@ -175,7 +175,9 @@ class SafariExtensionViewController: SFSafariExtensionViewController, WKScriptMe
} else if command == "createNewTab" { } else if command == "createNewTab" {
if let data = m.data, let url = URL(string: data) { if let data = m.data, let url = URL(string: data) {
SFSafariApplication.getActiveWindow { win in SFSafariApplication.getActiveWindow { win in
win?.openTab(with: url, makeActiveIfPossible: true, completionHandler: nil) win?.openTab(with: url, makeActiveIfPossible: true, completionHandler: { _ in
// Tab opened
})
} }
} }
} else if command == "reloadExtension" { } else if command == "reloadExtension" {