bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-17 00:33:44 +00:00
Code Issues Releases Wiki Activity

[PM-6769] [SM-1158] Fix Translation pipe issues on main (#8319)

Browse Source 
* Require init in i18n service.

this is needed to load translations and set translation locale

* No longer need to cast i18n

* Expose user preferred locale in i18nService

This is for correctly displaying `default` when no locale has been set in preferences components. The `locale$` observable should always resolve to the currently locale currently being translated to.
This commit is contained in:
Matt Gibson
2024-03-13 10:35:46 -05:00
committed by GitHub
parent e6fe0d1d13
commit 25f89e2a1c
8 changed files with 15 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/web/src/app/settings/preferences.component.ts
View File

@@ -141,7 +141,7 @@ export class PreferencesComponent implements OnInit {
),
enableFavicons: !(await this.settingsService.getDisableFavicon()),
theme: await firstValueFrom(this.themeStateService.selectedTheme$),
locale: (await firstValueFrom(this.i18nService.locale$)) ?? null,
locale: (await firstValueFrom(this.i18nService.userSetLocale$)) ?? null,
};
this.startingLocale = initialFormValues.locale;
this.form.setValue(initialFormValues, { emitEvent: false });