bitwarden/browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser synced 2025-12-06 00:13:28 +00:00
Code Issues Releases Wiki Activity

Fix angular performance issue on color-password.component (#14560)

Browse Source 
* Fix performance issue, by using track $index instead of character as it can contain duplicate characters

* Migrate component to use Angular signal inputs

* Make file ts-strict compliant

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
This commit is contained in:
Daniel James Smith
2025-05-08 23:19:09 +02:00
committed by GitHub
parent 9e467163db
commit 26ecf3191c
3 changed files with 13 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libs/vault/src/cipher-view/login-credentials/login-credentials-view.component.spec.ts
View File

@@ -168,7 +168,7 @@ describe("LoginCredentialsViewComponent", () => {
const passwordColor = passwordField.query(By.directive(ColorPasswordComponent));
expect(passwordColor.componentInstance.password).toBe(cipher.login.password);
expect(passwordColor.componentInstance.password()).toBe(cipher.login.password);
});
it("records event", () => {

2
libs/vault/src/components/password-history-view/password-history-view.component.spec.ts
View File

@@ -68,7 +68,7 @@ describe("PasswordHistoryViewComponent", () => {
it("renders all passwords", () => {
const passwords = fixture.debugElement.queryAll(By.directive(ColorPasswordComponent));
expect(passwords.map((password) => password.componentInstance.password)).toEqual([
expect(passwords.map((password) => password.componentInstance.password())).toEqual([
"bad-password-1",
"bad-password-2",
]);