From 29c438a8514eb1754a9e83f4d6dece5ef7ae57b4 Mon Sep 17 00:00:00 2001 From: Andreas Coroiu Date: Tue, 10 Jan 2023 10:48:22 +0100 Subject: [PATCH] [EC-598] fix: temporarily remove origin check --- libs/common/src/services/fido2/fido2.service.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libs/common/src/services/fido2/fido2.service.ts b/libs/common/src/services/fido2/fido2.service.ts index 6a227460bb8..60efe2c6a8a 100644 --- a/libs/common/src/services/fido2/fido2.service.ts +++ b/libs/common/src/services/fido2/fido2.service.ts @@ -10,7 +10,6 @@ import { CredentialRegistrationResult, Fido2Service as Fido2ServiceAbstraction, NoCredentialFoundError, - OriginMismatchError, } from "../../abstractions/fido2/fido2.service.abstraction"; import { CipherType } from "../../enums/cipherType"; import { Utils } from "../../misc/utils"; @@ -133,9 +132,10 @@ export class Fido2Service implements Fido2ServiceAbstraction { throw new NoCredentialFoundError(); } - if (credential.origin !== params.origin) { - throw new OriginMismatchError(); - } + // TODO: Google doesn't work with this. Look into how we're supposed to check this + // if (credential.origin !== params.origin) { + // throw new OriginMismatchError(); + // } await this.fido2UserInterfaceService.confirmCredential(credential.credentialId.encoded); } else {